From: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
To: Robert Noland <rnoland-4LXSwLOGEL8@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [RFC] nouveau: Add basic i2c sensor chip support
Date: Fri, 20 Nov 2009 20:02:56 +0000 [thread overview]
Message-ID: <20091120200256.GA30470@srcf.ucam.org> (raw)
In-Reply-To: <1258747177.31202.5.camel-it3iGQysvyiGwK4wanZbFg@public.gmane.org>
On Fri, Nov 20, 2009 at 01:59:37PM -0600, Robert Noland wrote:
> On Fri, 2009-11-20 at 18:43 +0000, Matthew Garrett wrote:
> > This one works better, including some amount of support for the internal
> > GPU sensor. It seems to give reasonable results on all the cards I have
> > here.
>
> So, I obviously have concerns/objections to allowing GPL code into drm.
> Especially, since this code doesn't do anything interesting or
> innovative that I can see. It just reads registers via i2c... I mean
> how else would you do it?
It contains code cut and paste from nvclock (a GPLed codebase) and uses
functions that are specific to the Linux kernel. I don't have the legal
expertise to be able to claim it's not a derived work.
--
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org
next prev parent reply other threads:[~2009-11-20 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 22:59 [RFC] nouveau: Add basic i2c sensor chip support Matthew Garrett
[not found] ` <1258671589-2079-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-20 18:43 ` Matthew Garrett
[not found] ` <20091120184325.GA29058-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2009-11-20 19:59 ` Robert Noland
[not found] ` <1258747177.31202.5.camel-it3iGQysvyiGwK4wanZbFg@public.gmane.org>
2009-11-20 20:02 ` Matthew Garrett [this message]
[not found] ` <20091120200256.GA30470-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2009-11-20 20:04 ` Stephane Marchesin
2010-03-10 16:46 ` Francesco Marella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120200256.GA30470@srcf.ucam.org \
--to=mjg59-1xo5oi07kqx4cg9nei1l7q@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=rnoland-4LXSwLOGEL8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.