All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: suppress stack overrun message for init_task
Date: Sat, 21 Nov 2009 18:31:04 +0800	[thread overview]
Message-ID: <20091121103104.GD2412@hack> (raw)
In-Reply-To: <4B06AEFE02000078000211F4@vpn.id2.novell.com>

On Fri, Nov 20, 2009 at 02:00:14PM +0000, Jan Beulich wrote:
>init_task doesn't get its stack end location set to STACK_END_MAGIC,
>and hence the message is confusing rather than helpful in this case.
>
>Signed-off-by: Jan Beulich <jbeulich@novell.com>
>

How about the patch below? It is totally untested. ;)

-------------->

init process should also write STACK_END_MAGIC to the
end of its stack.

Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

----
diff --git a/init/main.c b/init/main.c
index 5988deb..5a8f1b9 100644
--- a/init/main.c
+++ b/init/main.c
@@ -69,6 +69,7 @@
 #include <linux/kmemtrace.h>
 #include <linux/sfi.h>
 #include <linux/shmem_fs.h>
+#include <linux/magic.h>
 #include <trace/boot.h>
 
 #include <asm/io.h>
@@ -798,7 +799,9 @@ static void __init do_pre_smp_initcalls(void)
 
 static void run_init_process(char *init_filename)
 {
+	unsigned long *stack_end = end_of_stack(&init_task);
 	argv_init[0] = init_filename;
+	*stack_end = STACK_END_MAGIC;
 	kernel_execve(init_filename, argv_init, envp_init);
 }
 

  parent reply	other threads:[~2009-11-21 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 14:00 [PATCH] x86: suppress stack overrun message for init_task Jan Beulich
2009-11-21 10:17 ` Américo Wang
2009-11-21 10:31 ` Américo Wang [this message]
2009-11-23  8:41   ` Jan Beulich
2009-11-23 11:53 ` [tip:x86/debug] x86: Suppress " tip-bot for Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091121103104.GD2412@hack \
    --to=xiyou.wangcong@gmail.com \
    --cc=JBeulich@novell.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.