From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Mike Galbraith" <efault@gmx.de>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: [PATCH 1/3] perf symbols: fixup kernel_maps__fixup_end end map
Date: Sat, 21 Nov 2009 14:35:04 -0200 [thread overview]
Message-ID: <20091121163504.GI18283@ghostprotocols.net> (raw)
In-Reply-To: <1258821086-11521-1-git-send-email-acme@infradead.org>
Em Sat, Nov 21, 2009 at 02:31:24PM -0200, Arnaldo Carvalho de Melo escreveu:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> We better call this routine after both the kernel and modules are
> loaded, because as it was if there weren't modules it would be called,
s/would/would not/g
Ingo, if you see this before merging, please ammend the above comment
line :)
> resulting in kernel_map->end remaining at zero, so no map would be found
> and consequently the kernel symtab wouldn't get loaded, i.e. no kernel
> symbols would be resolved.
>
> Also this fixes another case, that is when we _have_ modules, but the
> last map would have its ->end address not set before we loaded its
> symbols, which would never happen because ->end was not set.
prev parent reply other threads:[~2009-11-21 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 16:31 [PATCH 1/3] perf symbols: fixup kernel_maps__fixup_end end map Arnaldo Carvalho de Melo
2009-11-21 16:31 ` [PATCH 2/3] perf symbols: Old versions of elf.h don't have NT_GNU_BUILD_ID Arnaldo Carvalho de Melo
2009-11-21 16:31 ` [PATCH 3/3] perf trace: read_tracing_data should die() another day Arnaldo Carvalho de Melo
2009-11-21 16:35 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091121163504.GI18283@ghostprotocols.net \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.