All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-mips@linux-mips.org, Michal Simek <monstr@monstr.eu>,
	Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH v5] MIPS: Add a high resolution sched_clock() via cnt32_to_63().
Date: Mon, 23 Nov 2009 11:36:50 +0100	[thread overview]
Message-ID: <20091123103650.GA30666@elte.hu> (raw)
In-Reply-To: <39b95d02b37cd75d275b231c31abb00aefda9078.1258972025.git.wuzhangjin@gmail.com>


* Wu Zhangjin <wuzhangjin@gmail.com> wrote:

> From: Wu Zhangjin <wuzhangjin@gmail.com>
> 
> (This v5 revision incorporates with the feedbacks from Ingo.)
> 
> This patch adds a cnt32_to_63() and MIPS c0 count based sched_clock(),
> which provides high resolution. and also, one new kernel option
> (HR_SCHED_CLOCK) is added to enable/disable this sched_clock().
> 
> Without it, the Ftrace for MIPS will give useless timestamp information.
> 
> Because cnt32_to_63() needs to be called at least once per half period
> to work properly, Differ from the old version, this v2 revision set up a
> kernel timer to ensure the requirement of some MIPSs which have short c0
> count period.
> 
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> ---
>  arch/mips/Kconfig                |   18 ++++++++++++
>  arch/mips/include/asm/time.h     |   15 ++++++++++
>  arch/mips/kernel/Makefile        |    1 +
>  arch/mips/kernel/csrc-r4k-hres.c |   54 ++++++++++++++++++++++++++++++++++++++
>  arch/mips/kernel/csrc-r4k.c      |    2 +
>  5 files changed, 90 insertions(+), 0 deletions(-)
>  create mode 100644 arch/mips/kernel/csrc-r4k-hres.c

Looks good!

Reviewed-by: Ingo Molnar <mingo@elte.hu>

Thanks,

	Ingo

  reply	other threads:[~2009-11-23 10:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 10:28 [PATCH v5] MIPS: Add a high resolution sched_clock() via cnt32_to_63() Wu Zhangjin
2009-11-23 10:36 ` Ingo Molnar [this message]
2009-11-23 13:11 ` Sergei Shtylyov
2009-11-23 17:46   ` Ingo Molnar
2009-11-26 18:15   ` Sergei Shtylyov
2009-11-27  1:07     ` Wu Zhangjin
2009-11-27  3:05     ` Wu Zhangjin
2009-11-27  4:45       ` David Daney
2009-11-27  8:35         ` Wu Zhangjin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123103650.GA30666@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-mips@linux-mips.org \
    --cc=monstr@monstr.eu \
    --cc=ralf@linux-mips.org \
    --cc=sshtylyov@ru.mvista.com \
    --cc=tglx@linutronix.de \
    --cc=wuzhangjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.