From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NCXWy-0003PN-BR for mharc-grub-devel@gnu.org; Mon, 23 Nov 2009 06:56:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCXWw-0003Oh-H2 for grub-devel@gnu.org; Mon, 23 Nov 2009 06:56:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCXWr-0003N2-EH for grub-devel@gnu.org; Mon, 23 Nov 2009 06:56:29 -0500 Received: from [199.232.76.173] (port=53604 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCXWr-0003Mw-7T for grub-devel@gnu.org; Mon, 23 Nov 2009 06:56:25 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:53954 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NCXWq-0000Hc-Ay for grub-devel@gnu.org; Mon, 23 Nov 2009 06:56:24 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NCXWk-00018p-QN; Mon, 23 Nov 2009 12:56:19 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NCXWh-0006Zz-DS; Mon, 23 Nov 2009 12:56:15 +0100 Date: Mon, 23 Nov 2009 12:56:15 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091123115615.GB25009@thorin> References: <20091122222822.GB5440@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091122222822.GB5440@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Jordi Mallach Subject: Re: gettextizing X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2009 11:56:30 -0000 On Sun, Nov 22, 2009 at 10:28:22PM +0000, Carles Pina i Estany wrote: > This one needs some cleanup before it can be gettextized. Translators should receive complete messages with no kludges in them. See info gettext "Preparing Strings" for more details on that. For example, these shouldn't be part of the translatable string: > - grub_printf ("\ > + grub_printf (_("\ > [ Minimal BASH-like line editing is supported. For the first word, TAB\n\ ^ > lists possible command completions. Anywhere else TAB lists possible\n\ ^^ > - device/file completions.%s ]\n\n", > + device/file completions.%s ]\n\n"), ^^ Eliminating the newlines is not trivial, but it fixes another problem: this string doesn't render well on non-80x25 terminals. > - grub_printf (" Booting a command list\n\n"); > + grub_printf (_(" Booting a command list\n\n")); > [...] > - grub_printf ("\nPress any key to continue..."); > + grub_printf (_("\nPress any key to continue...")); I'm not sure if the spaces and newlines here would be a problem. Jordi, any comment? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."