From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NCa9i-0006f1-F5 for mharc-grub-devel@gnu.org; Mon, 23 Nov 2009 09:44:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCa9f-0006cO-W7 for grub-devel@gnu.org; Mon, 23 Nov 2009 09:44:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCa9b-0006W5-Aj for grub-devel@gnu.org; Mon, 23 Nov 2009 09:44:39 -0500 Received: from [199.232.76.173] (port=46143 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCa9b-0006Vo-1P for grub-devel@gnu.org; Mon, 23 Nov 2009 09:44:35 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:40713 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NCa9a-00048g-M1 for grub-devel@gnu.org; Mon, 23 Nov 2009 09:44:34 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NCa9V-0001cc-CP for grub-devel@gnu.org; Mon, 23 Nov 2009 15:44:29 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NCa9U-0002YM-Oc for grub-devel@gnu.org; Mon, 23 Nov 2009 15:44:28 +0100 Date: Mon, 23 Nov 2009 15:44:28 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091123144428.GA9295@thorin> References: <4B093833.4020903@scarlet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B093833.4020903@scarlet.be> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Just a cosmetic question about grub_vprintf()? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2009 14:44:40 -0000 On Sun, Nov 22, 2009 at 01:10:11PM +0000, rubisher wrote: > But as far as the 1st parameter of grub_vsprintf is a pointer, > wouldn't it be better to write: > --- kern/misc.c.orig 2009-11-22 13:07:22.000000000 +0000 > +++ kern/misc.c 2009-11-22 13:07:51.000000000 +0000 > @@ -160,7 +160,7 @@ > { > int ret; > > - ret = grub_vsprintf (0, fmt, args); > + ret = grub_vsprintf (NULL, fmt, args); > return ret; > } Yes. But we have many of those, so we don't go huntin' them. If you'd like to help us, a patch that does this change in bulk would be welcome. Thanks -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."