All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: i_version, NFSv4 change attribute
Date: Mon, 23 Nov 2009 11:59:07 -0500	[thread overview]
Message-ID: <20091123165907.GC3292@fieldses.org> (raw)
In-Reply-To: <20091123164445.GB3292@fieldses.org>

On Mon, Nov 23, 2009 at 11:44:45AM -0500, J. Bruce Fields wrote:
> If the side we want to optimize is the modifications, I wonder if we
> could do all the i_version increments on *read* of i_version?:
> 
> 	- writes (and other inode modifications) set an "i_version_dirty"
> 	  flag.
> 	- reads of i_version clear the i_version_dirty flag, increment
> 	  i_version, and return the result.
> 
> As long as the reader sees i_version_flag set only after it sees the
> write that caused it, I think it all works?

Except I'm a little confused about how i_version behaves (and should
behave) on reboot.  Assuming it's currently correct, I think it's enough
to also increment i_version as above when writing out the inode.

--b.

  reply	other threads:[~2009-11-23 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-22 22:20 i_version, NFSv4 change attribute J. Bruce Fields
2009-11-23 11:48 ` tytso
2009-11-23 16:44   ` J. Bruce Fields
2009-11-23 16:59     ` J. Bruce Fields [this message]
2009-11-23 18:11     ` Trond Myklebust
2009-11-23 18:19       ` J. Bruce Fields
2009-11-23 18:37         ` Trond Myklebust
2009-11-23 18:51         ` tytso
2009-11-25 20:48           ` J. Bruce Fields
2009-11-23 18:35     ` tytso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123165907.GC3292@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.