From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754575AbZKWSLl (ORCPT ); Mon, 23 Nov 2009 13:11:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754336AbZKWSLl (ORCPT ); Mon, 23 Nov 2009 13:11:41 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:35074 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754324AbZKWSLk (ORCPT ); Mon, 23 Nov 2009 13:11:40 -0500 Date: Mon, 23 Nov 2009 19:10:49 +0100 From: Ingo Molnar To: Robin Holt , Andrew Morton , "H. Peter Anvin" Cc: tglx@linutronix.de, Jack Steiner , linux-kernel Subject: Re: [patch 0/8] x86: UV - XPC fixes with related support functionality V2. Message-ID: <20091123181049.GA5220@elte.hu> References: <20091119173157.337874000@alcatraz.americas.sgi.com> <20091123180321.GB15594@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091123180321.GB15594@elte.hu> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.5 _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > * Robin Holt wrote: > > > > > The UV BIOS has been updated to implement some of our interface > > functionality differently than originally expected. These patches > > update us to that working bios and include a few minor bug fixes > > which prevent us from doing significant testing on real hardware. > > > > Changes from V1: > > > > - Actually include the patch introducing the gru_read_gpa. This > > was missed in the V1 submission. > > > > - One additional BIOS change has the OS no longer passing blade > > to the BIOS when registering a message queue watchlist. > > Note, the patches are a bit hard to review without diffstats - mind > generating them for future patches? Also, putting a 'summary' diffstat > (the total diffstat effect of all patches) into the 0/8 description mail > is common courtesy that is much welcome by maintainers and reviewers as > well. Ah, sorry - they were there, just merged together with the patch so i missed them. Regarding the patches - i still very much dislike how the code interfaces to the 'BIOS'. The drivers/misc/sgi-xp/ code looks rather messy. Why isnt a pure hardware interface exposed, as both hpa and me suggested in the past? Anyway ... these bits got merged via -mm in the past so i guess it could be done there in the future too - the series does not look horrible - but the whole concept ought to be done in a cleaner way. Ingo