From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755914AbZKWTnb (ORCPT ); Mon, 23 Nov 2009 14:43:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754499AbZKWTna (ORCPT ); Mon, 23 Nov 2009 14:43:30 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:47127 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbZKWTna (ORCPT ); Mon, 23 Nov 2009 14:43:30 -0500 Date: Mon, 23 Nov 2009 11:43:34 -0800 From: "Paul E. McKenney" To: Christoph Lameter Cc: Pekka Enberg , Peter Zijlstra , linux-mm@kvack.org, mpm@selenic.com, LKML , Nick Piggin Subject: Re: lockdep complaints in slab allocator Message-ID: <20091123194334.GD6774@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20091118181202.GA12180@linux.vnet.ibm.com> <84144f020911192249l6c7fa495t1a05294c8f5b6ac8@mail.gmail.com> <1258709153.11284.429.camel@laptop> <84144f020911200238w3d3ecb38k92ca595beee31de5@mail.gmail.com> <1258714328.11284.522.camel@laptop> <4B067816.6070304@cs.helsinki.fi> <1258729748.4104.223.camel@laptop> <1259002800.5630.1.camel@penberg-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2009 at 01:30:50PM -0600, Christoph Lameter wrote: > On Mon, 23 Nov 2009, Pekka Enberg wrote: > > > That turns out to be _very_ hard. How about something like the following > > untested patch which delays slab_destroy() while we're under nc->lock. > > Code changes to deal with a diagnostic issue? Indeed! At least if we want the diagnostics to have any value, we do need to avoid false alarms. Same reasoning as for gcc warnings, right? Thanx, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id E79326B0044 for ; Mon, 23 Nov 2009 14:43:45 -0500 (EST) Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e9.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id nANJc2s3028178 for ; Mon, 23 Nov 2009 14:38:02 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nANJhZNB105916 for ; Mon, 23 Nov 2009 14:43:35 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nANJhY0K011625 for ; Mon, 23 Nov 2009 14:43:35 -0500 Date: Mon, 23 Nov 2009 11:43:34 -0800 From: "Paul E. McKenney" Subject: Re: lockdep complaints in slab allocator Message-ID: <20091123194334.GD6774@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20091118181202.GA12180@linux.vnet.ibm.com> <84144f020911192249l6c7fa495t1a05294c8f5b6ac8@mail.gmail.com> <1258709153.11284.429.camel@laptop> <84144f020911200238w3d3ecb38k92ca595beee31de5@mail.gmail.com> <1258714328.11284.522.camel@laptop> <4B067816.6070304@cs.helsinki.fi> <1258729748.4104.223.camel@laptop> <1259002800.5630.1.camel@penberg-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Pekka Enberg , Peter Zijlstra , linux-mm@kvack.org, mpm@selenic.com, LKML , Nick Piggin List-ID: On Mon, Nov 23, 2009 at 01:30:50PM -0600, Christoph Lameter wrote: > On Mon, 23 Nov 2009, Pekka Enberg wrote: > > > That turns out to be _very_ hard. How about something like the following > > untested patch which delays slab_destroy() while we're under nc->lock. > > Code changes to deal with a diagnostic issue? Indeed! At least if we want the diagnostics to have any value, we do need to avoid false alarms. Same reasoning as for gcc warnings, right? Thanx, Paul -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org