Re: Subject: [PATCH 2/6] bna: Brocade 10Gb Ethernet device driver

[Stephen Hemminger <shemminger@vyatta.com>]

On Mon, 23 Nov 2009 19:51:01 -0800
Rasesh Mody <rmody@brocade.com> wrote:

> +/**
> + *  bna_rxf_frame_stats_get()
> + *
> + *  For RxF "rxf_id", it loads frame statistics into "stats_ptr".
> + *
> + * @param[in]  dev     - pointer to BNA device structure
> + * @param[in]  rxf_id  - rx-function ID.
> + * @param[out]  stats_ptr - pointer to stats structure to fill
> + *
> + * @return BNA_OK   - successful
> + * @return BNA_FAIL - failed on sanity checks.
> + */
> +void bna_rxf_frame_stats_get(struct bna_dev *dev, unsigned int rxf_id,
> +	struct bna_stats_rxf **stats_ptr)
> +{
> +
> +	BNA_ASSERT(rxf_id < BNA_RXF_ID_MAX);
> +
> +	*stats_ptr = &dev->stats.rxf_stats[rxf_id];
> +}

20 lines to do the work of 1!