From: Ralf Baechle <ralf@linux-mips.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-pci <linux-pci@vger.kernel.org>,
linux@arm.linux.org.uk, "tony.luck" <tony.luck@intel.com>,
fenghua.yu@intel.com, "David S.Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, Peter Anvin <hpa@zytor.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-mips@linux-mips.org,
David Daney <ddaney@caviumnetworks.com>
Subject: Re: Time to make PCI_MSI default y ?
Date: Tue, 24 Nov 2009 12:53:09 +0000 [thread overview]
Message-ID: <20091124125309.GB5749@linux-mips.org> (raw)
In-Reply-To: <1259030388.20596.5.camel@concordia>
On Tue, Nov 24, 2009 at 01:39:48PM +1100, Michael Ellerman wrote:
> Having just hit a build-break caused by a distro building with
> PCI_MSI=n, I set out to make it default y for powerpc. Unfortunately
> that's not possible, because it's in drivers/pci/Kconfig.
>
> So is it time to make it default y for everyone? It seems to me having
> it off is more likely to cause problems than having it on these days,
> though I'm not sure if that is true for all archs.
>
> An arch that really didn't want it default y could conditionally select
> ARCH_SUPPORTS_MSI, like x86 does already.
On MIPS the age of MSI only recently started; once single platform (Cavium)
out of all the many uses it. Cavium does a "select ARCH_SUPPORTS_MSI" but
not "select PCI_MSI" because not all platform variants actually have PCI.
We should not give a user a chance to select something wrong in kconfig
thus automatically as many options for a platform as possible is a good
thing - after all the kconfig dialog for any given platfrom has become
painfully long. And we really should have to avoid users having to know
that the Frobnic 2000 they're trying to upgrade the kernel for requires
MSI to work ...
Ralf
next parent reply other threads:[~2009-11-24 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1259030388.20596.5.camel@concordia>
2009-11-24 12:53 ` Ralf Baechle [this message]
2009-11-24 21:09 ` Time to make PCI_MSI default y ? Benjamin Herrenschmidt
2009-11-25 0:31 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124125309.GB5749@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michael@ellerman.id.au \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.