All of lore.kernel.org
 help / color / mirror / Atom feed
From: tytso@mit.edu
To: Akira Fujita <a-fujita@rs.jp.nec.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3]ext4: Fix double-free of blocks with EXT4_IOC_MOVE_EXT
Date: Tue, 24 Nov 2009 10:30:25 -0500	[thread overview]
Message-ID: <20091124153024.GJ2183@thunk.org> (raw)
In-Reply-To: <4B03A189.6000109@rs.jp.nec.com>

On Wed, Nov 18, 2009 at 04:26:01PM +0900, Akira Fujita wrote:
> ext4: Fix double-free of blocks with EXT4_IOC_MOVE_EXT
> 
> From: Akira Fujita <a-fujita@rs.jp.nec.com>
> 
> ext4_move_extent() calls ext4_discard_preallocations() to discard inode PAs
> of orig and donor inodes in its beginning.
> But the following case (1-4 steps) triggers the double-free of blocks,
> so move ext4_discard_preallocations() to the end of ext4_move_extents().

Thanks, applied to the ext4 patch queue.

					- Ted

      reply	other threads:[~2009-11-24 15:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18  7:26 [PATCH 1/3]ext4: Fix double-free of blocks with EXT4_IOC_MOVE_EXT Akira Fujita
2009-11-24 15:30 ` tytso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091124153024.GJ2183@thunk.org \
    --to=tytso@mit.edu \
    --cc=a-fujita@rs.jp.nec.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.