From: tytso@mit.edu
To: Akira Fujita <a-fujita@rs.jp.nec.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/3]ext4: Initialize moved_len before calling ext4_move_extents()
Date: Tue, 24 Nov 2009 10:31:22 -0500 [thread overview]
Message-ID: <20091124153122.GK2183@thunk.org> (raw)
In-Reply-To: <4B03A192.5000201@rs.jp.nec.com>
On Wed, Nov 18, 2009 at 04:26:10PM +0900, Akira Fujita wrote:
> ext4: initialize moved_len before calling ext4_move_extents()
>
> From: Kazuya Mio <k-mio@sx.jp.nec.com>
>
> moved_len of struct move_extent is used to notify
> exchanged blocks count to the user space.
> So at the beginning of the EXT4_IOC_MOVE_EXT,
> moved_len should be always zero.
> Without this patch, if wrong moved_len is passed from the user space,
> EXT4_IOC_MOVE_EXT will return wrong blocks count.
Applied with the following rewording of the patch description:
ext4: initialize moved_len before calling ext4_move_extents()
From: Kazuya Mio <k-mio@sx.jp.nec.com>
The move_extent.moved_len is used to pass back the number of exchanged
blocks count to user space. Currently the caller must clear this
field; but we spend more code space checking for this requirement than
simply zeroing the field ourselves, so let's just make life easier for
everyone all around.
Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
Signed-off-by: Akira Fujita <a-fujita@rs.jp.nec.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
- Ted
prev parent reply other threads:[~2009-11-24 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 7:26 [PATCH 2/3]ext4: Initialize moved_len before calling ext4_move_extents() Akira Fujita
2009-11-24 15:31 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124153122.GK2183@thunk.org \
--to=tytso@mit.edu \
--cc=a-fujita@rs.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.