From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH 7/8] spi_mpc8xxx: Turn qe_mode into flags Date: Tue, 24 Nov 2009 18:41:45 +0300 Message-ID: <20091124154145.GA23040@oksana.dev.rtsoft.ru> References: <20091012164841.GA32214@oksana.dev.rtsoft.ru> <20091012164925.GG4578@oksana.dev.rtsoft.ru> <3E303C4F-CE29-470F-B34A-3413F31BC23C@kernel.crashing.org> <1259039016.16367.118.camel@pasglop> Reply-To: avorontsov@ru.mvista.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: David Brownell , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net, Andrew Morton To: Benjamin Herrenschmidt Return-path: Content-Disposition: inline In-Reply-To: <1259039016.16367.118.camel@pasglop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org List-Id: linux-spi.vger.kernel.org T24gVHVlLCBOb3YgMjQsIDIwMDkgYXQgMDQ6MDM6MzZQTSArMTEwMCwgQmVuamFtaW4gSGVycmVu c2NobWlkdCB3cm90ZToKWy4uLl0KPiBUaGlzIHBhdGNoIGJyZWFrcyBteSA2eHggY29uZmlnOgo+ IAo+IC9ob21lL2JlbmgvbGludXgtcG93ZXJwYy10ZXN0L2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMv ODN4eC9tcGM4MzJ4X3JkYi5jOiBJbiBmdW5jdGlvbiDigJhvZl9mc2xfc3BpX3Byb2Jl4oCZOgo+ IC9ob21lL2JlbmgvbGludXgtcG93ZXJwYy10ZXN0L2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvODN4 eC9tcGM4MzJ4X3JkYi5jOjc3OiBlcnJvcjog4oCYc3RydWN0IGZzbF9zcGlfcGxhdGZvcm1fZGF0 YeKAmSBoYXMgbm8gbWVtYmVyIG5hbWVkIOKAmHFlXwo+IAo+IFRoZSByZWFzb24gaXMgdGhhdCB0 aGUgbXBjODMyeF9yZGIuYyBjb2RlIHN0aWxsIHVzZXMgdGhlIGxlZ2FjeSBwcm9iaW5nCj4gbWV0 aG9kLiBUaGUgZml4IGlzIG5vdCB0b3RhbGx5IHRyaXZpYWwgYXMgdGhlIG5ldyBmbGFncyBhcmUg ZGVmaW5lZCBpbnNpZGUKPiBzcGlfbXBjOHh4eC5jCgpUaGFua3MgZm9yIG5vdGljaW5nLiBJIGlu ZGVlZCBmb3Jnb3QgYWJvdXQgdGhlIGxlZ2FjeSBzdHVmZi4gOi0vCgo+IElmIHlvdSBhcmUgZ29p bmcgdG8ga2VlcCB0aGUgZmxhZ3MgaW4gdGhlIC5jIGZpbGUgeW91IHByb2JhYmx5IGFsc28gd2Fu dAo+IHRvIHJlbW92ZSB0aGUgcGxhdGZvcm0gZGV2aWNlIGRlZmluaXRpb24gZnJvbSBmc2xfZGV2 aWNlcy5oIGFueXdheXMgYXMKPiB0aGVyZSdzIG5vIHBvaW50IGV4cG9zaW5nIHRvIHRoZSB3b3Js ZCBhIHN0cnVjdHVyZSB3aXRoIGEgImZsYWdzIiBtZW1iZXIKPiBpZiB0aGUgZGVmaW5pdGlvbiBv ZiB0aG9zZSBmbGFncyBpc24ndCBhbHNvIGV4cG9zZWQuCgpZZXAuIFRob3VnaCwgSUlSQyBKb2Fr aW0gYXNrZWQgdG8ga2VlcCB0aGUgbGVnYWN5IGJpbmRpbmdzIGZvciBzb21lCnRpbWUgKHVudGls IHdlIGltcGxlbWVudCBTUEkgY2hpcC1zZWxlY3QgZnJhbWV3b3JrPykuLi4gc28gZm9yIG5vdwp3 ZSdsbCBoYXZlIHRvIGxlYXZlIHdlIHRoZSBleHBvc2VkIGZsYWdzLgoKVGhhbmtzIGFnYWluLAoK LS0gCkFudG9uIFZvcm9udHNvdgplbWFpbDogY2JvdWF0bWFpbHJ1QGdtYWlsLmNvbQppcmM6Ly9p cmMuZnJlZW5vZGUubmV0L2JkMgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5v emxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [213.79.90.228]) by ozlabs.org (Postfix) with ESMTP id 598C8B6F04 for ; Wed, 25 Nov 2009 02:41:58 +1100 (EST) Date: Tue, 24 Nov 2009 18:41:45 +0300 From: Anton Vorontsov To: Benjamin Herrenschmidt Subject: Re: [PATCH 7/8] spi_mpc8xxx: Turn qe_mode into flags Message-ID: <20091124154145.GA23040@oksana.dev.rtsoft.ru> References: <20091012164841.GA32214@oksana.dev.rtsoft.ru> <20091012164925.GG4578@oksana.dev.rtsoft.ru> <3E303C4F-CE29-470F-B34A-3413F31BC23C@kernel.crashing.org> <1259039016.16367.118.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1259039016.16367.118.camel@pasglop> Cc: David Brownell , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net, Andrew Morton Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Nov 24, 2009 at 04:03:36PM +1100, Benjamin Herrenschmidt wrote: [...] > This patch breaks my 6xx config: > > /home/benh/linux-powerpc-test/arch/powerpc/platforms/83xx/mpc832x_rdb.c: In function ‘of_fsl_spi_probe’: > /home/benh/linux-powerpc-test/arch/powerpc/platforms/83xx/mpc832x_rdb.c:77: error: ‘struct fsl_spi_platform_data’ has no member named ‘qe_ > > The reason is that the mpc832x_rdb.c code still uses the legacy probing > method. The fix is not totally trivial as the new flags are defined inside > spi_mpc8xxx.c Thanks for noticing. I indeed forgot about the legacy stuff. :-/ > If you are going to keep the flags in the .c file you probably also want > to remove the platform device definition from fsl_devices.h anyways as > there's no point exposing to the world a structure with a "flags" member > if the definition of those flags isn't also exposed. Yep. Though, IIRC Joakim asked to keep the legacy bindings for some time (until we implement SPI chip-select framework?)... so for now we'll have to leave we the exposed flags. Thanks again, -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933486AbZKXQhN (ORCPT ); Tue, 24 Nov 2009 11:37:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932214AbZKXQhM (ORCPT ); Tue, 24 Nov 2009 11:37:12 -0500 Received: from imap.ru.mvista.com ([213.79.90.228]:3968 "EHLO buildserver.ru.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758123AbZKXQhL (ORCPT ); Tue, 24 Nov 2009 11:37:11 -0500 Date: Tue, 24 Nov 2009 18:41:45 +0300 From: Anton Vorontsov To: Benjamin Herrenschmidt Cc: Kumar Gala , David Brownell , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net, Andrew Morton Subject: Re: [PATCH 7/8] spi_mpc8xxx: Turn qe_mode into flags Message-ID: <20091124154145.GA23040@oksana.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com References: <20091012164841.GA32214@oksana.dev.rtsoft.ru> <20091012164925.GG4578@oksana.dev.rtsoft.ru> <3E303C4F-CE29-470F-B34A-3413F31BC23C@kernel.crashing.org> <1259039016.16367.118.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1259039016.16367.118.camel@pasglop> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2009 at 04:03:36PM +1100, Benjamin Herrenschmidt wrote: [...] > This patch breaks my 6xx config: > > /home/benh/linux-powerpc-test/arch/powerpc/platforms/83xx/mpc832x_rdb.c: In function ‘of_fsl_spi_probe’: > /home/benh/linux-powerpc-test/arch/powerpc/platforms/83xx/mpc832x_rdb.c:77: error: ‘struct fsl_spi_platform_data’ has no member named ‘qe_ > > The reason is that the mpc832x_rdb.c code still uses the legacy probing > method. The fix is not totally trivial as the new flags are defined inside > spi_mpc8xxx.c Thanks for noticing. I indeed forgot about the legacy stuff. :-/ > If you are going to keep the flags in the .c file you probably also want > to remove the platform device definition from fsl_devices.h anyways as > there's no point exposing to the world a structure with a "flags" member > if the definition of those flags isn't also exposed. Yep. Though, IIRC Joakim asked to keep the legacy bindings for some time (until we implement SPI chip-select framework?)... so for now we'll have to leave we the exposed flags. Thanks again, -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2