From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/pvdisplay.c tools/repor ...
Date: 24 Nov 2009 17:07:10 -0000 [thread overview]
Message-ID: <20091124170710.13545.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2009-11-24 17:07:09
Modified files:
. : WHATS_NEW
tools : pvdisplay.c reporter.c
Log message:
Add missing vg_release to pvs and pvdisplay to fix memory leak.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1326&r2=1.1327
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvdisplay.c.diff?cvsroot=lvm2&r1=1.53&r2=1.54
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/reporter.c.diff?cvsroot=lvm2&r1=1.57&r2=1.58
--- LVM2/WHATS_NEW 2009/11/24 16:13:02 1.1326
+++ LVM2/WHATS_NEW 2009/11/24 17:07:09 1.1327
@@ -1,5 +1,6 @@
Version 2.02.56 -
====================================
+ Add missing vg_release to pvs and pvdisplay to fix memory leak.
Do not try to unlock VG which is not locked in _process_one_vg.
Move persistent filter dump to more appropriate place.
Refresh device filters before full device rescan in lvmcache.
--- LVM2/tools/pvdisplay.c 2009/07/15 05:50:22 1.53
+++ LVM2/tools/pvdisplay.c 2009/11/24 17:07:09 1.54
@@ -31,10 +31,11 @@
vg_name = pv_vg_name(pv);
vg = vg_read(cmd, vg_name, (char *)&pv->vgid, 0);
if (vg_read_error(vg)) {
- log_error("Skipping volume group %s", vg_name);
+ log_error("Skipping volume group %s", vg_name);
+ vg_release(vg);
/* FIXME If CLUSTERED should return ECMD_PROCESSED here */
- return ECMD_FAILED;
- }
+ return ECMD_FAILED;
+ }
/*
* Replace possibly incomplete PV structure with new one
--- LVM2/tools/reporter.c 2009/11/03 15:50:44 1.57
+++ LVM2/tools/reporter.c 2009/11/24 17:07:09 1.58
@@ -143,6 +143,7 @@
vg = vg_read(cmd, vg_name, (char *)&pv->vgid, 0);
if (vg_read_error(vg)) {
log_error("Skipping volume group %s", vg_name);
+ vg_release(vg);
return ECMD_FAILED;
}
reply other threads:[~2009-11-24 17:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124170710.13545.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.