From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: MX3: fix CPU revision number detection
Date: Tue, 24 Nov 2009 18:36:57 +0100 [thread overview]
Message-ID: <20091124173657.GC14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091121192249.GF13956@n2100.arm.linux.org.uk>
On Sat, Nov 21, 2009 at 07:22:49PM +0000, Russell King - ARM Linux wrote:
> On Sat, Nov 21, 2009 at 07:00:37PM +0000, Russell King - ARM Linux wrote:
> > On Sat, Nov 21, 2009 at 05:19:24PM +0100, Daniel Mack wrote:
> > > +#include <asm/io.h>
> >
> > I see red. linux/io.h please.
>
> BTW, as a reminder, the reason I pick up on these soo much is because
> I've configured my mail client (mutt) to highlight them:
>
> color body white red "\\+.*(#include <(asm|mach)/(gp)?io\.h>|return -1|default n)"
>
> which matches new uses of 'asm/io.h', 'mach/io.h', 'asm/gpio.h',
> 'mach/gpio.h', 'return -1' and 'default n' in patches.
That is quite handy, but when my own patches are parsed by mutt, it's
usually too late ;) I'll hack a git-pre-commit script to prevent that in
the future. Or does anyone have that ready yet?
Daniel
next prev parent reply other threads:[~2009-11-24 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 16:19 [PATCH] ARM: MX3: fix CPU revision number detection Daniel Mack
2009-11-21 19:00 ` Russell King - ARM Linux
2009-11-21 19:17 ` Daniel Mack
2009-11-23 10:42 ` Sascha Hauer
2009-11-21 19:22 ` Russell King - ARM Linux
2009-11-24 17:36 ` Daniel Mack [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-21 14:15 Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124173657.GC14091@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.