From: Samuel Ortiz <sameo@linux.intel.com>
To: Daniel J Blueman <daniel.blueman@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] twl4030: fix ELF section mismatch...
Date: Wed, 25 Nov 2009 00:37:55 +0100 [thread overview]
Message-ID: <20091124233754.GK8290@sortiz.org> (raw)
In-Reply-To: <6278d2220911231054r15891be8k8f8130fd47cddca2@mail.gmail.com>
On Mon, Nov 23, 2009 at 06:54:06PM +0000, Daniel J Blueman wrote:
> Since twl4030_probe is only called from functions in the init ELF
> section, annotate it so.
>
> Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Mark, thanks for carrying this one with your twl4030 branch.
Cheers,
Samuel.
> ---
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index a1c47ee..2fe514d 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -763,7 +763,7 @@ static int twl4030_remove(struct i2c_client *client)
> }
>
> /* NOTE: this driver only handles a single twl4030/tps659x0 chip */
> -static int
> +static int __init
> twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
> {
> int status;
> --
> Daniel J Blueman
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2009-11-24 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 18:54 [patch] twl4030: fix ELF section mismatch Daniel J Blueman
2009-11-24 23:37 ` Samuel Ortiz [this message]
2009-11-25 10:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124233754.GK8290@sortiz.org \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=daniel.blueman@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.