From: Florian Fainelli <florian@openwrt.org>
To: Yoichi Yuasa <yuasa@linux-mips.org>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds-cobalt: use resource_size()
Date: Wed, 25 Nov 2009 10:41:44 +0100 [thread overview]
Message-ID: <200911251041.44776.florian@openwrt.org> (raw)
In-Reply-To: <20091125133359.000d43c0.yuasa@linux-mips.org>
Hi Yoichi,
On Wednesday 25 November 2009 05:33:59 Yoichi Yuasa wrote:
> Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
> Cc: Florian Fainelli <florian@openwrt.org>
Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
> drivers/leds/leds-cobalt-qube.c | 2 +-
> drivers/leds/leds-cobalt-raq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-cobalt-qube.c
> b/drivers/leds/leds-cobalt-qube.c index 8816806..de19753 100644
> --- a/drivers/leds/leds-cobalt-qube.c
> +++ b/drivers/leds/leds-cobalt-qube.c
> @@ -43,7 +43,7 @@ static int __devinit cobalt_qube_led_probe(struct
> platform_device *pdev) if (!res)
> return -EBUSY;
>
> - led_port = ioremap(res->start, res->end - res->start + 1);
> + led_port = ioremap(res->start, resource_size(res));
> if (!led_port)
> return -ENOMEM;
>
> diff --git a/drivers/leds/leds-cobalt-raq.c
> b/drivers/leds/leds-cobalt-raq.c index defc212..438d483 100644
> --- a/drivers/leds/leds-cobalt-raq.c
> +++ b/drivers/leds/leds-cobalt-raq.c
> @@ -84,7 +84,7 @@ static int __devinit cobalt_raq_led_probe(struct
> platform_device *pdev) if (!res)
> return -EBUSY;
>
> - led_port = ioremap(res->start, res->end - res->start + 1);
> + led_port = ioremap(res->start, resource_size(res));
> if (!led_port)
> return -ENOMEM;
>
--
--
WBR, Florian
prev parent reply other threads:[~2009-11-25 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 4:33 [PATCH] leds-cobalt: use resource_size() Yoichi Yuasa
2009-11-25 9:41 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911251041.44776.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=yuasa@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.