From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Shirley Ma <mashirle@us.ibm.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Avi Kivity <avi@redhat.com>,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [PATCH 1/1] Defer skb allocation for both mergeable buffers and big packets in virtio_net
Date: Wed, 25 Nov 2009 13:40:29 +0200 [thread overview]
Message-ID: <20091125114029.GA9333@redhat.com> (raw)
In-Reply-To: <200911252050.21907.rusty@rustcorp.com.au>
On Wed, Nov 25, 2009 at 08:50:21PM +1030, Rusty Russell wrote:
> On Wed, 25 Nov 2009 07:45:30 pm Michael S. Tsirkin wrote:
> > Hmm, is it really worth it to save a header copy if it's linear? We are
> > going to access it anyway, and it fits into one cacheline nicely. On
> > the other hand we have more code making life harder for compiler and
> > processor.
>
> Not sure: I think there would be many places where it would be useful.
>
> We do a similar thing in the kernel to inspect non-linear packets, and
> it's served us well.
You mean this gives measureable speedup? Okay ...
> Cheers,
> Rusty.
next prev parent reply other threads:[~2009-11-25 11:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 6:15 [PATCH 1/1] Defer skb allocation for both mergeable buffers and big packets in virtio_net Shirley Ma
2009-11-20 6:19 ` Eric Dumazet
2009-11-20 16:08 ` Shirley Ma
2009-11-20 16:21 ` Shirley Ma
2009-11-23 1:08 ` Rusty Russell
2009-11-23 16:07 ` Shirley Ma
2009-11-23 22:24 ` Rusty Russell
2009-11-23 23:27 ` Shirley Ma
2009-11-24 11:37 ` Michael S. Tsirkin
2009-11-24 14:36 ` Anthony Liguori
2009-11-24 16:04 ` Michael S. Tsirkin
2009-11-24 16:04 ` Michael S. Tsirkin
2009-11-25 0:15 ` Rusty Russell
2009-11-25 0:12 ` Rusty Russell
2009-11-25 9:15 ` Michael S. Tsirkin
2009-11-25 10:20 ` Rusty Russell
2009-11-25 11:40 ` Michael S. Tsirkin [this message]
2009-11-23 19:01 ` Shirley Ma
2009-11-23 9:43 ` Michael S. Tsirkin
2009-11-23 16:18 ` Shirley Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125114029.GA9333@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=hollisb@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mashirle@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.