Re: [PATCH 1/1] TWL4030 keypad: keypad lock / unlock

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Wed, Nov 25, 2009 at 04:22:17PM +0200, Onkalo Samu wrote:

> Something like that:

The userspace interface looks reasonable to me but...

> +		return count;
> +	}
> +	input_dev->disabled = i;

> should this be a counter or boolean? Or should this be in driver itself
> and not in input system.

I'd expect a boolean - userspace can refcount itself if it needs to, but
it'd be strange if configuration written into sysfs didn't always take
effect.

> +	if (i)
> +		input_dev->disable(input_dev);
> +	else
> +		input_dev->enable(input_dev);

...it'd seem more natural to have the sense of the sysfs file be the
other way around, but that is a matter of taste.  It just feels better
to me for "true" to mean "on".

I don't know what the best way to sync with the device being open and
in use is, though.