All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] nhk8815: added lcd support
Date: Wed, 25 Nov 2009 16:23:26 +0100	[thread overview]
Message-ID: <20091125152326.GA30679@mail.gnudd.com> (raw)
In-Reply-To: <20091122225321.BF829E34A27@gemini.denx.de>

I'm almost done with the requested changes on this patch set, will post
V2 this evening after re-running ./makeall as needed.

I've a question, though:

>> +extern int nhk8815_backlight_on(void);		/* in ./lcd.c */
> 
> Please move prototype decl;arations to some header file.

Unfortunately, there is no suitable file. It's just that I split
code related to different drivers in different files, for better
housekeeping.  These two are called nhk8815-something as they are
board-specific anyways.

Should I create a local header file in this same board directory, with
just the two prototypes? Or "ifndef __ASSEMBLY__ in the board config
file is better?  I'd better ask first to avoid a V3 just for this
detail.

Thanks
/alessandro

      reply	other threads:[~2009-11-25 15:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09 11:16 [U-Boot] [PATCH 0/8] ARM Nomadik: video and keypad for nhk8815 (and RFC inside) Alessandro Rubini
2009-10-09 11:16 ` [U-Boot] [PATCH 1/8] video: add amba-clcd prime-cell Alessandro Rubini
2009-11-22 22:40   ` Wolfgang Denk
2009-10-09 11:17 ` [U-Boot] [PATCH 2/8] include/nomadik.h: add physical address for cldc Alessandro Rubini
2009-10-09 11:17 ` [U-Boot] [PATCH 3/8] drivers/misc: add stmpe2401 port extender and keypad controller Alessandro Rubini
2009-11-22 22:47   ` Wolfgang Denk
2009-10-09 11:17 ` [U-Boot] [PATCH 4/8] nhk8815.h: define we need stmpe Alessandro Rubini
2009-10-09 11:17 ` [U-Boot] [PATCH 5/8] lcd: make 16bpp work Alessandro Rubini
2009-11-22 22:43   ` Wolfgang Denk
2009-10-09 11:17 ` [U-Boot] [PATCH 6/8] nhk8815: added keypad Alessandro Rubini
2009-11-22 22:49   ` Wolfgang Denk
2009-11-22 22:57     ` Alessandro Rubini
2009-10-09 11:17 ` [U-Boot] [PATCH 7/8] nhk8815: start lower in RAM, so the 800x480 frame buffer fits Alessandro Rubini
2009-11-22 22:51   ` Wolfgang Denk
2009-10-09 11:18 ` [U-Boot] [PATCH 8/8] nhk8815: added lcd support Alessandro Rubini
2009-11-22 22:53   ` Wolfgang Denk
2009-11-25 15:23     ` Alessandro Rubini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091125152326.GA30679@mail.gnudd.com \
    --to=rubini-list@gnudd.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.