All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: eran liberty <eran.liberty@gmail.com>
Cc: balajirrao@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: kobjects: mark cleaned up kobjects as unitialized
Date: Wed, 25 Nov 2009 07:41:06 -0800	[thread overview]
Message-ID: <20091125154106.GA24842@suse.de> (raw)
In-Reply-To: <20091125152747.GB24498@suse.de>

On Wed, Nov 25, 2009 at 07:27:47AM -0800, Greg KH wrote:
> > but basically you can demonstrate the problem with this simple code:
> > 
> > struct device dev;
> > while(1) {
> >   dev->release = dummy_release_function_that_does_nothing;
> 
> WTF!!!
> 
> Ugh, if I see one more person try to "trick" the kernel from reporting
> this error by providing a "dummy" release function, I'm going to go find
> a kitten to kick.
> 
> Seriously, why are you blatently ignoring the warning that the kernel is
> trying to be nice and give to you?  Do we just invent messages that need
> to be worked around?

Oh, and before anyone thinks that I'm being too harsh here, again, refer
to Documentation/kobject.txt:
	Note that the kernel will warn you if you forget to provide a
	release() method.  Do not try to get rid of this warning by
	providing an "empty" release function; you will be mocked
	mercilessly by the kobject maintainer if you attempt this.

Hence my mocking.

thanks,

greg k-h

      reply	other threads:[~2009-11-25 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25  9:27 kobjects: mark cleaned up kobjects as unitialized eran liberty
2009-11-25 12:35 ` Greg KH
2009-11-25 14:27   ` eran liberty
2009-11-25 15:27     ` Greg KH
2009-11-25 15:41       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091125154106.GA24842@suse.de \
    --to=gregkh@suse.de \
    --cc=balajirrao@gmail.com \
    --cc=eran.liberty@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.