From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/17] ARM: pxa/raumfeld: add rotary encoder support
Date: Wed, 25 Nov 2009 16:50:31 +0100 [thread overview]
Message-ID: <20091125155031.GQ29442@buzzloop.caiaq.de> (raw)
In-Reply-To: <4B0D4CAE.50709@compulab.co.il>
On Wed, Nov 25, 2009 at 05:26:38PM +0200, Mike Rapoport wrote:
> Daniel Mack wrote:
> > static void __init raumfeld_common_init(void)
> > {
> > enable_irq_wake(IRQ_WAKEUP0);
> > @@ -174,6 +197,12 @@ static void __init raumfeld_common_init(void)
> >
> > static void __init raumfeld_controller_init(void)
> > {
> > + struct platform_device *raumfeld_controller_devices[] = {
> > + &rotary_encoder_device,
> > + };
>
> Any reason to keep the devices array inside the function? I think it makes the
> code less readable.
Ok - changed for the next round.
Thanks,
Daniel
next prev parent reply other threads:[~2009-11-25 15:50 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 10:42 ARM: pxa: add support for Raumfeld audio devices Daniel Mack
2009-11-25 10:42 ` [PATCH 01/17] ARM: pxa/raumfeld: add basic structure for devices Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 15:44 ` Daniel Mack
2009-11-25 16:51 ` Marek Vasut
2009-11-25 17:06 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 02/17] ARM: pxa/raumfeld: add GPIO definitions Daniel Mack
2009-11-25 10:42 ` [PATCH 03/17] ARM: pxa/raumfeld: add SMSC9220 ethernet support Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 15:49 ` Daniel Mack
2009-11-25 16:56 ` Russell King - ARM Linux
2009-11-26 17:55 ` Daniel Mack
2009-11-25 10:42 ` [PATCH 04/17] ARM: pxa/raumfeld: add OHCI function Daniel Mack
2009-11-25 10:42 ` [PATCH 05/17] ARM: pxa/raumfeld: add rotary encoder support Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 15:50 ` Daniel Mack [this message]
2009-11-25 16:59 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 06/17] ARM: pxa/raumfeld: add GPIO buttons Daniel Mack
2009-11-25 10:42 ` [PATCH 07/17] ARM: pxa/raumfeld: add GPIO connected LEDs Daniel Mack
2009-11-25 10:42 ` [PATCH 08/17] ARM: pxa/raumfeld: add one-wire function Daniel Mack
2009-11-25 17:02 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 09/17] ARM: pxa/raumfeld: add NAND partitions Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 10:42 ` [PATCH 10/17] ARM: pxa/raumfeld: add framebuffer and backlight devices Daniel Mack
2009-11-25 10:42 ` [PATCH 11/17] ARM: pxa/raumfeld: add SPI controlled devices Daniel Mack
2009-11-25 10:42 ` [PATCH 12/17] ARM: pxa/raumfeld: add audio related functions Daniel Mack
2009-11-25 11:41 ` Mark Brown
2009-11-25 12:28 ` Daniel Mack
2009-11-25 13:07 ` Mark Brown
2009-11-25 13:53 ` Daniel Mack
2009-11-25 14:00 ` Mark Brown
2009-11-25 17:07 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 13/17] ARM: pxa/raumfeld: add Marvell Libertas via SDIO Daniel Mack
2009-11-25 11:49 ` Mark Brown
2009-11-25 13:04 ` Daniel Mack
2009-11-25 13:36 ` Mark Brown
2009-11-25 10:42 ` [PATCH 14/17] ARM: pxa/raumfeld: add power supply framework Daniel Mack
2009-11-25 10:42 ` [PATCH 15/17] ARM: pxa/raumfeld: add support for I2C controlled devices Daniel Mack
2009-11-25 10:42 ` [PATCH 16/17] ALSA: ARM: add Raumfeld audio support Daniel Mack
2009-11-25 10:42 ` Daniel Mack
2009-11-25 11:02 ` Mark Brown
2009-11-25 11:02 ` Mark Brown
2009-11-25 12:24 ` Daniel Mack
2009-11-25 12:24 ` Daniel Mack
2009-11-25 13:29 ` Mark Brown
2009-11-25 13:29 ` Mark Brown
2009-11-26 17:51 ` Daniel Mack
2009-11-26 17:51 ` Daniel Mack
2009-11-25 10:42 ` [PATCH 17/17] ARM: pxa/raumfeld: Add defconfig Daniel Mack
2009-11-25 11:27 ` ARM: pxa: add support for Raumfeld audio devices Mike Rapoport
2009-11-25 12:14 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125155031.GQ29442@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.