All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Kevin Hickey <khickey@netlogicmicro.com>,
	Manuel Lauss <manuel.lauss@googlemail.com>,
	Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
Date: Wed, 25 Nov 2009 16:19:52 +0000	[thread overview]
Message-ID: <20091125161952.GB10490@linux-mips.org> (raw)
In-Reply-To: <1259165736.13740.7.camel@falcon.domain.org>

On Thu, Nov 26, 2009 at 12:15:36AM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
> Date:   Thu, 26 Nov 2009 00:15:36 +0800
> To: Kevin Hickey <khickey@netlogicmicro.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>,
> 	Manuel Lauss <manuel.lauss@googlemail.com>,
> 	Linux-MIPS <linux-mips@linux-mips.org>
> Subject: Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
> Content-Type: text/plain; charset="UTF-8"
> 
> On Wed, 2009-11-25 at 08:42 -0600, Kevin Hickey wrote:
> > On Tue, 2009-11-24 at 16:30 +0000, Ralf Baechle wrote:
> > > On Tue, Nov 24, 2009 at 05:24:57PM +0100, Manuel Lauss wrote:
> > > 
> > > > On Tue, Nov 24, 2009 at 10:33 AM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > > > [...]
> > > > > This patch will only enable that option when the DEBUG_KERNEL is
> > > > > enabled.
> > > > 
> > > > How about making it independent from DEBUG_KERNEL altogether?  If find
> > > > it useful even without full debug info.
> > 
> > I agree with Manuel here.  I often build release kernels that benefit
> > from EARLY_PRINTK.  Why not make EARLY_PRINTK a selectable option in the
> > config?  Coupling it to DEBUG_KERNEL seems confusing. 
> 
> Hello,
> 
> Ralf have moved the EARLY_PRINTK to Kconfig.debug and removed the
> dependency on DEBUG_KERNEL in his -queue repository ;) Just as the X86
> and some other ARCHs does:
> 
> http://www.linux-mips.org/git?p=linux-queue.git
> 
> [...]
> +config EARLY_PRINTK
> +       bool "Early printk" if EMBEDDED
> +       depends on SYS_HAS_EARLY_PRINTK
> +       default y
> [...]
> 
> So, it is okay now, please ignore this patch ;)

Okay, dropped then.

Thanks!

  Ralf

      reply	other threads:[~2009-11-25 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24  9:33 [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency Wu Zhangjin
2009-11-24 16:24 ` Manuel Lauss
2009-11-24 16:30   ` Ralf Baechle
2009-11-25 14:42     ` Kevin Hickey
2009-11-25 16:15       ` Wu Zhangjin
2009-11-25 16:19         ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091125161952.GB10490@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=khickey@netlogicmicro.com \
    --cc=linux-mips@linux-mips.org \
    --cc=manuel.lauss@googlemail.com \
    --cc=wuzhangjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.