From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NDQkj-0007cV-G5 for mharc-grub-devel@gnu.org; Wed, 25 Nov 2009 17:54:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDQkh-0007bL-5c for grub-devel@gnu.org; Wed, 25 Nov 2009 17:54:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDQkc-0007XL-Ep for grub-devel@gnu.org; Wed, 25 Nov 2009 17:54:22 -0500 Received: from [199.232.76.173] (port=51301 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDQkc-0007XE-8s for grub-devel@gnu.org; Wed, 25 Nov 2009 17:54:18 -0500 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:49618 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDQkb-0003P1-FE for grub-devel@gnu.org; Wed, 25 Nov 2009 17:54:17 -0500 Received: from pinux (82-45-164-87.cable.ubr06.hari.blueyonder.co.uk [82.45.164.87]) by mail.pina.cat (Postfix) with ESMTP id 6C507288F2FE5 for ; Wed, 25 Nov 2009 23:54:16 +0100 (CET) Received: by pinux (Postfix, from userid 1000) id D52871561F; Wed, 25 Nov 2009 22:54:22 +0000 (GMT) Date: Wed, 25 Nov 2009 22:54:22 +0000 From: Carles Pina i Estany To: The development of GNU GRUB Message-ID: <20091125225422.GA1599@pina.cat> References: <20091122235013.GA12142@pina.cat> <20091123120412.GE25009@thorin> <20091125000812.GA30522@pina.cat> <20091125003059.GA31362@pina.cat> <20091125185513.GA4997@thorin> <20091125220938.GA32313@pina.cat> <4B0DAE05.60604@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B0DAE05.60604@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: gettextize normal/menu_text.c (print_timeout) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2009 22:54:23 -0000 Hi, On Nov/25/2009, Vladimir '??-coder/phcoder' Serbinenko wrote: > Carles Pina i Estany wrote: > > Hi, > > > > On Nov/25/2009, Robert Millan wrote: > > > >> On Wed, Nov 25, 2009 at 12:30:59AM +0000, Carles Pina i Estany wrote: > >> > >>> BTW, I left spaces on the left of lot of strings. In my opinion I would > >>> delete it and call print_spaces(3);. Fine? (or call grub_printf (" "); > >>> ). > >>> > >> Yes. > >> > > > > ok! > > > > > > > >>> - grub_printf ("\n\ > >>> + grub_printf (_("\ > >>> Minimum Emacs-like screen editing is supported. TAB lists\n\ > >>> completions. Press Ctrl-x to boot, Ctrl-c for a command-line\n\ > >>> - or ESC to return menu."); > >>> + or ESC to return menu.")); > >>> > >> These are still not right. We can't have newlines in the middle of a > >> translatable string. > >> > > > > I disagree. We have to give to the translators the minimum unit of > > "sense", and in this case it's three lines. We cannot force translators > > to translate the same sentence line by line because: > > > > a) they will not have enough context > > b) they cannot rephrase enough > > c) maybe in other language the first line would be longer and the second > > shorter, and if we split they cannot fix (less flexibility for them). > > > > Agree with me? > > > > > The real problem is that these newlines are hardcoded into string > whereas they should be put on runtime since terminal width may vary (the > string as is is tailored for 80 columns terminal) this makes more sense (I didn't had in mind that the terminal width can vary). I will delete the new lines and make a function that splits the string after WIDTH_TERMINAL without splitting words. I thought that Robert wanted to have 3 strings to translate, one per line, not one long dynamic string. Thanks, -- Carles Pina i Estany http://pinux.info