All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Youquan,Song" <youquan.song@linux.intel.com>
To: herbert@gondor.apana.org.au
Cc: linux-kernel@vger.kernel.org, ying.huang@intel.com,
	kent.liu@intel.com, youquan.song@intel.com
Subject: [PATCH]crypto: Fix aesni algorithm implementation without test
Date: Wed, 25 Nov 2009 19:42:27 -0500	[thread overview]
Message-ID: <20091126004226.GA32230@youquan-linux.bj.intel.com> (raw)

when load aesni-intel driver,kernel will report no test for some algorithm
with AES-NI. The strange information as following:

alg: No test for __aes-aesni (__driver-aes-aesni)
alg: No test for __ecb-aes-aesni (__driver-ecb-aes-aesni)
alg: No test for __cbc-aes-aesni (__driver-cbc-aes-aesni)
alg: No test for __ecb-aes-aesni (cryptd(__driver-ecb-aes-aesni)

crypto_alg's cra_name is use to descript algorithm itself, do not care the 
concrete implement. So this patch unify them and also can fix the algorithm
implementation without test. 

Signed-off-by: Youquan, Song <youquan.song@intel.com>
---

diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c
index 585edeb..455bbf3 100644
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -161,7 +161,7 @@ static void __aes_decrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
 }
 
 static struct crypto_alg __aesni_alg = {
-	.cra_name		= "__aes-aesni",
+	.cra_name		= "aes",
 	.cra_driver_name	= "__driver-aes-aesni",
 	.cra_priority		= 0,
 	.cra_flags		= CRYPTO_ALG_TYPE_CIPHER,
@@ -230,7 +230,7 @@ static int ecb_decrypt(struct blkcipher_desc *desc,
 }
 
 static struct crypto_alg blk_ecb_alg = {
-	.cra_name		= "__ecb-aes-aesni",
+	.cra_name		= "ecb(aes)",
 	.cra_driver_name	= "__driver-ecb-aes-aesni",
 	.cra_priority		= 0,
 	.cra_flags		= CRYPTO_ALG_TYPE_BLKCIPHER,
@@ -300,7 +300,7 @@ static int cbc_decrypt(struct blkcipher_desc *desc,
 }
 
 static struct crypto_alg blk_cbc_alg = {
-	.cra_name		= "__cbc-aes-aesni",
+	.cra_name		= "cbc(aes)",
 	.cra_driver_name	= "__driver-cbc-aes-aesni",
 	.cra_priority		= 0,
 	.cra_flags		= CRYPTO_ALG_TYPE_BLKCIPHER,

             reply	other threads:[~2009-11-25 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26  0:42 Youquan,Song [this message]
2009-11-26  0:13 ` [PATCH]crypto: Fix aesni algorithm implementation without test Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091126004226.GA32230@youquan-linux.bj.intel.com \
    --to=youquan.song@linux.intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kent.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    --cc=youquan.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.