From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: Jerone Young <jerone.young@canonical.com>,
Andrew Lutomirski <luto@mit.edu>,
linux-thinkpad@linux-thinkpad.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] Set osi=Linux for the ThinkPad X200s
Date: Thu, 26 Nov 2009 05:07:48 +0000 [thread overview]
Message-ID: <20091126050748.GA7874@srcf.ucam.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0911251317480.3950@localhost.localdomain>
On Wed, Nov 25, 2009 at 01:24:50PM -0500, Len Brown wrote:
> Have these been verified as necessary to make sound work on
> the specified models, or are these speculative patches?
To clarify - these patches do *nothing* to make sound work. They change
the behaviour of the mute key from changing the hardware state of the
mixer and not sending a key event to instead sending a key event and
requring that software perform the change. The behavioural change is
primarily cosmetic rather than functional. I'm not convinced that this
is a sensible thing to do at this point in the release cycle, given that
we have no testing of what other behavioural changes the firmware may
make.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-11-26 5:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 16:47 [PATCH] Set osi=Linux for the ThinkPad X200s Andrew Lutomirski
2009-11-09 16:54 ` Matthew Garrett
2009-11-09 17:49 ` Andrew Lutomirski
2009-11-09 17:54 ` Matthew Garrett
2009-11-10 9:24 ` [ltp] " Henrique de Moraes Holschuh
2009-11-10 12:42 ` Matthew Garrett
2009-11-10 13:32 ` Andrew Lutomirski
2009-11-10 14:14 ` Matthew Garrett
2009-11-10 17:49 ` Henrique de Moraes Holschuh
2009-11-10 9:19 ` [ltp] " Henrique de Moraes Holschuh
2009-11-25 4:50 ` Len Brown
2009-11-25 17:30 ` Jerone Young
2009-11-25 18:24 ` Len Brown
2009-11-25 19:56 ` Jerone Young
2009-11-26 5:07 ` Matthew Garrett [this message]
2009-11-26 6:00 ` Andrew Lutomirski
2009-11-26 17:02 ` Stefan Monnier
2009-11-26 13:43 ` Jerone Young
2009-11-25 19:01 ` Andrew Lutomirski
2009-11-30 5:47 ` Jerone Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126050748.GA7874@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jerone.young@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-thinkpad@linux-thinkpad.org \
--cc=luto@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.