From: Jens Axboe <jens.axboe@oracle.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: czoccolo@gmail.com, Vivek Goyal <vgoyal@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfq: Make use of service count to estimate the rb_key offset
Date: Thu, 26 Nov 2009 09:14:09 +0100 [thread overview]
Message-ID: <20091126081409.GL8742@kernel.dk> (raw)
In-Reply-To: <4B0E1E2F.9080604@cn.fujitsu.com>
On Thu, Nov 26 2009, Gui Jianfeng wrote:
> Hi Jens, Czoccolo
>
> For the moment, different workload cfq queues are put into different
> service trees. But CFQ still uses "busy_queues" to estimate rb_key
> offset when inserting a cfq queue into a service tree. I think this
> isn't appropriate, and it should make use of service tree count to do
> this estimation. This patch is for for-2.6.33 branch.
Makes sense, we've before discussed that using ->busy_queues isn't very
good, as it's not a stable count. service_tree count isn't that much
better, but for for-2.6.33 it does make more sense.
--
Jens Axboe
next prev parent reply other threads:[~2009-11-26 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 6:20 [PATCH] cfq: Make use of service count to estimate the rb_key offset Gui Jianfeng
2009-11-26 8:14 ` Jens Axboe [this message]
2009-11-26 9:08 ` Corrado Zoccolo
2009-11-27 1:42 ` Gui Jianfeng
2009-11-27 8:16 ` Corrado Zoccolo
2009-11-30 3:02 ` Gui Jianfeng
2009-11-30 8:38 ` Jens Axboe
2009-11-30 15:36 ` Vivek Goyal
2009-11-30 16:01 ` Corrado Zoccolo
2009-11-30 16:46 ` Vivek Goyal
2009-11-30 21:56 ` Corrado Zoccolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126081409.GL8742@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=czoccolo@gmail.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.