From: Matt Fleming <matt@console-pimps.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh: mach-ecovec24: modify memory area calculation
Date: Thu, 26 Nov 2009 10:51:30 +0000 [thread overview]
Message-ID: <20091126105130.GA6612@console-pimps.org> (raw)
In-Reply-To: <u8wdto9qh.wl%morimoto.kuninori@renesas.com>
On Thu, Nov 26, 2009 at 07:34:30PM +0900, Kuninori Morimoto wrote:
> diff --git a/arch/sh/include/mach-ecovec24/mach/romimage.h b/arch/sh/include/mach-ecovec24/mach/romimage.h
> index 1c8787e..115495d 100644
> --- a/arch/sh/include/mach-ecovec24/mach/romimage.h
> +++ b/arch/sh/include/mach-ecovec24/mach/romimage.h
> @@ -11,10 +11,13 @@
> icbi @r0
>
> /* jump to cached area */
> - mova 2f, r0
> + mov.l 2f, r1
> + mova 3f, r0
> + sub r1, r0
> jmp @r0
> nop
>
> .align 2
> 1 : .long 0xa8000000
> -2 :
> +2 : .long 0x20000000 /* 0xA0000000 - 0x80000000 */
> +3 :
> --
> 1.6.3.3
>
I think both of these patches should be using the variable
"cached_to_uncached", rather than hard coding the value 0x20000000.
next prev parent reply other threads:[~2009-11-26 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 10:34 [PATCH 1/2] sh: mach-ecovec24: modify memory area calculation Kuninori Morimoto
2009-11-26 10:51 ` Matt Fleming [this message]
2009-11-26 11:08 ` Kuninori Morimoto
2009-11-26 11:46 ` Matt Fleming
2009-11-30 2:16 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126105130.GA6612@console-pimps.org \
--to=matt@console-pimps.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.