All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 03/12] wl1251: fix error handling in wl1251_op_config()
Date: Thu, 26 Nov 2009 17:08:43 +0200	[thread overview]
Message-ID: <20091126150843.917.6633.stgit@tikku> (raw)
In-Reply-To: <20091126150141.917.35278.stgit@tikku>

From: Kalle Valo <kalle.valo@nokia.com>

Not all return values were checked and one exit from function didn't put
firmware sleep after the error.

Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
---
 drivers/net/wireless/wl12xx/wl1251_main.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/wl1251_main.c b/drivers/net/wireless/wl12xx/wl1251_main.c
index e9fb2ca..8ba6742 100644
--- a/drivers/net/wireless/wl12xx/wl1251_main.c
+++ b/drivers/net/wireless/wl12xx/wl1251_main.c
@@ -641,20 +641,25 @@ static int wl1251_op_config(struct ieee80211_hw *hw, u32 changed)
 		 * through the bss_info_changed() hook.
 		 */
 		ret = wl1251_ps_set_mode(wl, STATION_POWER_SAVE_MODE);
+		if (ret < 0)
+			goto out_sleep;
 	} else if (!(conf->flags & IEEE80211_CONF_PS) &&
 		   wl->psm_requested) {
 		wl1251_debug(DEBUG_PSM, "psm disabled");
 
 		wl->psm_requested = false;
 
-		if (wl->psm)
+		if (wl->psm) {
 			ret = wl1251_ps_set_mode(wl, STATION_ACTIVE_MODE);
+			if (ret < 0)
+				goto out_sleep;
+		}
 	}
 
 	if (conf->power_level != wl->power_level) {
 		ret = wl1251_acx_tx_power(wl, conf->power_level);
 		if (ret < 0)
-			goto out;
+			goto out_sleep;
 
 		wl->power_level = conf->power_level;
 	}


  parent reply	other threads:[~2009-11-26 15:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26 15:08 [PATCH 00/12] wl1251 WMM support and minor fixes Kalle Valo
2009-11-26 15:08 ` [PATCH 01/12] wl1251: add tx queue status to debugfs Kalle Valo
2009-11-26 15:08 ` [PATCH 02/12] wl1251: print a debug message when tx_queue is full Kalle Valo
2009-11-26 15:08 ` Kalle Valo [this message]
2009-11-26 15:08 ` [PATCH 04/12] wl1251: reduce ELP wakeup timeout Kalle Valo
2009-11-26 15:08 ` [PATCH 05/12] wl1251: simplify ELP wakeup time calculation Kalle Valo
2009-11-26 15:09 ` [PATCH 06/12] wl1251: fix payload alignment Kalle Valo
2009-11-26 15:13   ` Kalle Valo
2009-11-26 18:13     ` Johannes Berg
2009-11-27 11:08       ` Kalle Valo
2009-11-27 11:11         ` Johannes Berg
2009-11-27 11:32           ` Kalle Valo
2009-11-26 15:09 ` [PATCH 07/12] wl1251: use __dev_alloc_skb() on RX Kalle Valo
2009-11-26 15:09 ` [PATCH 08/12] wl1251: implement acx_ac_cfg to configure hardware queues Kalle Valo
2009-11-26 15:09 ` [PATCH 09/12] wl1251: implement wl1251_acx_tid_cfg() Kalle Valo
2009-11-26 15:09 ` [PATCH 10/12] wl1251: implement WMM Kalle Valo
2009-11-26 15:09 ` [PATCH 11/12] wl1251: update tx_hdr when aliging skb in tx Kalle Valo
2009-11-26 15:09 ` [PATCH 12/12] wl1251: enable WMM Kalle Valo
2009-11-27 13:30 ` [PATCH 00/12] wl1251 WMM support and minor fixes Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091126150843.917.6633.stgit@tikku \
    --to=kalle.valo@iki.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.