From: Anton Blanchard <anton@samba.org>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, msb@google.com, fweisbec@gmail.com
Subject: PATCH: softlockup: Fix hung_task_check_count sysctl
Date: Fri, 27 Nov 2009 13:28:20 +1100 [thread overview]
Message-ID: <20091127022820.GU32182@kryten> (raw)
I'm seeing spikes of up to 0.5ms in khungtaskd on a large machine. To reduce
this source of jitter I tried setting hung_task_check_count to 0:
# echo 0 > /proc/sys/kernel/hung_task_check_count
which didn't have the intended response. Change to a post increment of
max_count, so a value of 0 means check 0 tasks.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: linux.trees.git/kernel/hung_task.c
===================================================================
--- linux.trees.git.orig/kernel/hung_task.c 2009-11-27 13:11:46.000000000 +1100
+++ linux.trees.git/kernel/hung_task.c 2009-11-27 13:11:57.000000000 +1100
@@ -144,7 +144,7 @@ static void check_hung_uninterruptible_t
rcu_read_lock();
do_each_thread(g, t) {
- if (!--max_count)
+ if (!max_count--)
goto unlock;
if (!--batch_count) {
batch_count = HUNG_TASK_BATCHING;
next reply other threads:[~2009-11-27 2:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 2:28 Anton Blanchard [this message]
2009-11-27 2:40 ` PATCH: softlockup: Fix hung_task_check_count sysctl Frederic Weisbecker
2009-11-27 2:46 ` Américo Wang
2009-11-27 2:55 ` Frederic Weisbecker
2009-11-27 3:02 ` Américo Wang
2009-11-27 4:22 ` Frederic Weisbecker
2009-11-27 5:48 ` [tip:core/softlockup] " tip-bot for Anton Blanchard
2009-11-30 19:13 ` PATCH: " Mandeep Singh Baines
2009-11-30 20:21 ` Mandeep Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127022820.GU32182@kryten \
--to=anton@samba.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=msb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.