From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NEC2r-0004m3-9i for mharc-grub-devel@gnu.org; Fri, 27 Nov 2009 20:24:17 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NEC2p-0004lb-Tu for grub-devel@gnu.org; Fri, 27 Nov 2009 20:24:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NEC2l-0004hQ-8i for grub-devel@gnu.org; Fri, 27 Nov 2009 20:24:15 -0500 Received: from [199.232.76.173] (port=42990 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NEC2l-0004hN-6e for grub-devel@gnu.org; Fri, 27 Nov 2009 20:24:11 -0500 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:53846 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NEC2l-0001sy-4k for grub-devel@gnu.org; Fri, 27 Nov 2009 20:24:11 -0500 Received: from pinux (82-45-164-87.cable.ubr06.hari.blueyonder.co.uk [82.45.164.87]) by mail.pina.cat (Postfix) with ESMTP id F16B8281B6D0B for ; Sat, 28 Nov 2009 02:24:09 +0100 (CET) Received: by pinux (Postfix, from userid 1000) id 57B7D1582C; Sat, 28 Nov 2009 01:24:17 +0000 (GMT) Date: Sat, 28 Nov 2009 01:24:17 +0000 From: Carles Pina i Estany To: grub-devel@gnu.org Message-ID: <20091128012417.GA8530@pina.cat> References: <20091128000948.GA2764@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091128000948.GA2764@pina.cat> User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: gettext: normal_menu.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Nov 2009 01:24:16 -0000 Hi, On Nov/28/2009, Carles Pina i Estany wrote: > Find attached the patch and ChangeLog for normal_menu.c new version with two improvements: a) uses grubcharwidth to calculate the width of the string (for the characters that doesn't have any width, etc.). This has to be consistent with GRUB_TERM_WIDTH. b) ensure that strings that doesn't fit in one line will be correctly handled and indented. This can happen in languages where the separator is not a space. I've checked if there is some unicode character to say "word separator" and I didn't find, so it adds the newline wherever is fine for the terminal width. Question: getstringwidth should be in normal/menu_text.c like it's now or in kern/term.c like grub_getchardwidth. Some suggestions before committing? Thanks, -- Carles Pina i Estany http://pinux.info