From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [PATCH v2 2/2] cld: read the cld.port file using
 g_file_get_contents
Date: Sat, 28 Nov 2009 16:02:13 -0700
Message-ID: <20091128160213.55edb813@redhat.com>
References: <1259375029-22050-1-git-send-email-cmccabe@alumni.cmu.edu>
	<20091128105815.7b5cd149@redhat.com>
	<4B1194D1.50103@garzik.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
In-Reply-To: <4B1194D1.50103@garzik.org>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Jeff Garzik <jeff@garzik.org>
Cc: Colin McCabe <cmccabe@alumni.cmu.edu>, Project Hail List <hail-devel@vger.kernel.org>, zaitcev@redhat.com

On Sat, 28 Nov 2009 16:23:29 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> > +++ cld-tip/server/server.c
> > @@ -722,7 +741,7 @@ static int net_open_any(void)
> >
> >   	if (cld_srv.port_file) {
> >   		char portstr[7];
> > -		snprintf(portstr, sizeof(portstr), "%u\n", port);
> > +		snprintf(portstr, sizeof(portstr), "%u", port);
> >   		return net_write_port(cld_srv.port_file, portstr);
> >   	}
> >   	return 0;
> >
> > Our PID files contain a linefeed, as a courtesy to those who
> > examine them from a shell. But CLD's contains two.

> Agreed... wanna wrap that in a signed-off-by?  :)

Sure, I can do it. Although, it was intended as a hint for Colin
about the kind of bugs we have scattered all over (probably).
This one was harmless.

-- pete