From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH] ALSA: ASoc: Add regulator support to CS4270 codec driver Date: Sun, 29 Nov 2009 09:35:54 +0100 Message-ID: <20091129083554.GC14091@buzzloop.caiaq.de> References: <20091126160351.GB10674@rakim.wolfsonmicro.main> <20091126174245.GJ14091@buzzloop.caiaq.de> <20091127112550.GA29821@rakim.wolfsonmicro.main> <20091127124139.GR14091@buzzloop.caiaq.de> <20091127133225.GB17711@rakim.wolfsonmicro.main> <4B1186B8.6070606@freescale.com> <4B11A19D.4070301@freescale.com> <20091129004433.GZ14091@buzzloop.caiaq.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from buzzloop.caiaq.de (buzzloop.caiaq.de [212.112.241.133]) by alsa0.perex.cz (Postfix) with ESMTP id 083E92463E for ; Sun, 29 Nov 2009 09:35:58 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: "alsa-devel@alsa-project.org" , Mark Brown , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Sat, Nov 28, 2009 at 10:34:12PM -0600, Timur Tabi wrote: > On Sat, Nov 28, 2009 at 6:44 PM, Daniel Mack wrote: > > > It does compile and does boot, > > Does it compile and boot on a Freescale MPC8610 HPCD? No, I don't have such a board. But I see no reason why it shouldn't compile as no part of the patch is platform depended. And for configurations with CONFIG_REGULATOR=n, all the new calls are NOPs. The only heads-up is that for CONFIG_REGULATOR=y, you now need to provide the regulators the codec driver needs. Anyway - I'll rebase the driver to 'for-2.6.33' so you can give it a try. Thanks, Daniel