All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carles Pina i Estany <carles@pina.cat>
To: grub-devel@gnu.org
Subject: Re: var=foo should be valid?
Date: Sun, 29 Nov 2009 18:45:03 +0000	[thread overview]
Message-ID: <20091129184503.GA22104@pina.cat> (raw)
In-Reply-To: <20091129183936.GB19323@pina.cat>


Hi,

On Nov/29/2009, Carles Pina i Estany wrote:

> Right now in Grub2 a user could do:
> name=john
> set name=john
> 
> both are valid.
> 
> (first one has a bug but very easy to fix, even thought I would maybe
> refactor this code to implement in other way)
> 
> Question that arised in IRC: should be support the first one or not? Two
> interfaces for the same thing?

my opinion: doesn't matter (a lot)

And because "doesn't matter": we can only accept "set name=john".

So we avoid bugs like it happened now, more simple and users wondering
"if there are two ways means that set is doing something that it's not
happening in name=foo, maybe setting a reference and not copying the
string*? maybe exporting**?".

*: happens in VBA
**: someone could think that if we accept without and with set it's
exporting like export name=foo in Bash

-- 
Carles Pina i Estany
	http://pinux.info



  reply	other threads:[~2009-11-29 18:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-29 18:39 var=foo should be valid? Carles Pina i Estany
2009-11-29 18:45 ` Carles Pina i Estany [this message]
2009-11-29 18:50   ` Carles Pina i Estany
2009-11-30  9:39   ` Colin Watson
2009-11-30 13:48     ` Carles Pina i Estany
2009-12-04 21:16     ` Robert Millan
2009-12-04 21:21 ` Robert Millan
2009-12-04 21:55   ` Carles Pina i Estany
2009-12-12  0:04     ` Carles Pina i Estany
2009-12-13 12:45       ` Carles Pina i Estany

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091129184503.GA22104@pina.cat \
    --to=carles@pina.cat \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.