From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NEola-0007UJ-Jp for mharc-grub-devel@gnu.org; Sun, 29 Nov 2009 13:45:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NEolZ-0007UD-Cf for grub-devel@gnu.org; Sun, 29 Nov 2009 13:45:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NEolV-0007Tk-UJ for grub-devel@gnu.org; Sun, 29 Nov 2009 13:45:01 -0500 Received: from [199.232.76.173] (port=54086 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NEolV-0007Th-OB for grub-devel@gnu.org; Sun, 29 Nov 2009 13:44:57 -0500 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:40581 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NEolV-0002rh-91 for grub-devel@gnu.org; Sun, 29 Nov 2009 13:44:57 -0500 Received: from pinux (82-45-164-87.cable.ubr06.hari.blueyonder.co.uk [82.45.164.87]) by mail.pina.cat (Postfix) with ESMTP id EBB95288FBA3F for ; Sun, 29 Nov 2009 19:44:55 +0100 (CET) Received: by pinux (Postfix, from userid 1000) id 5C75EE194F; Sun, 29 Nov 2009 18:45:03 +0000 (GMT) Date: Sun, 29 Nov 2009 18:45:03 +0000 From: Carles Pina i Estany To: grub-devel@gnu.org Message-ID: <20091129184503.GA22104@pina.cat> References: <20091129183936.GB19323@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091129183936.GB19323@pina.cat> User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: var=foo should be valid? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2009 18:45:01 -0000 Hi, On Nov/29/2009, Carles Pina i Estany wrote: > Right now in Grub2 a user could do: > name=john > set name=john > > both are valid. > > (first one has a bug but very easy to fix, even thought I would maybe > refactor this code to implement in other way) > > Question that arised in IRC: should be support the first one or not? Two > interfaces for the same thing? my opinion: doesn't matter (a lot) And because "doesn't matter": we can only accept "set name=john". So we avoid bugs like it happened now, more simple and users wondering "if there are two ways means that set is doing something that it's not happening in name=foo, maybe setting a reference and not copying the string*? maybe exporting**?". *: happens in VBA **: someone could think that if we accept without and with set it's exporting like export name=foo in Bash -- Carles Pina i Estany http://pinux.info