All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>,
	akpm@linux-foundation.org, Amerigo Wang <amwang@redhat.com>
Subject: [Patch] percpu: remove two suspicious break statements
Date: Mon, 30 Nov 2009 04:12:02 -0500	[thread overview]
Message-ID: <20091130091501.4507.28683.sendpatchset@localhost.localdomain> (raw)

These two break statements seem to be very suspicious,
they are at the end of the statements inside the loop.
Remove them.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Tejun Heo <tj@kernel.org>

---
diff --git a/mm/percpu.c b/mm/percpu.c
index 5adfc26..dbcfee8 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -917,7 +917,6 @@ static void pcpu_depopulate_chunk(struct pcpu_chunk *chunk, int off, int size)
 	pcpu_for_each_unpop_region(chunk, rs, re, page_start, page_end) {
 		if (rs == page_start && re == page_end)
 			return;
-		break;
 	}
 
 	/* immutable chunks can't be depopulated */
@@ -972,7 +971,6 @@ static int pcpu_populate_chunk(struct pcpu_chunk *chunk, int off, int size)
 	pcpu_for_each_pop_region(chunk, rs, re, page_start, page_end) {
 		if (rs == page_start && re == page_end)
 			goto clear;
-		break;
 	}
 
 	/* need to allocate and map pages, this chunk can't be immutable */

             reply	other threads:[~2009-11-30  9:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30  9:12 Amerigo Wang [this message]
2009-11-30 11:09 ` [Patch] percpu: remove two suspicious break statements Tejun Heo
2009-11-30 19:01   ` Christoph Lameter
2009-12-01  0:01     ` [PATCH] percpu: explain quick paths in pcpu_[de]populate_chunk() Tejun Heo
2009-12-01  2:02       ` Cong Wang
2009-12-01  5:00         ` Tejun Heo
2009-12-01  5:09           ` Tejun Heo
2009-12-01  5:40             ` Cong Wang
2009-12-01  5:47               ` Tejun Heo
2009-12-01  6:35                 ` Cong Wang
2009-12-01  6:59                   ` Tejun Heo
2009-12-01  7:13                     ` [PATCH] percpu: refactor the code " Cong Wang
2009-12-01 14:31                       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091130091501.4507.28683.sendpatchset@localhost.localdomain \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.