From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NF6cn-00021R-R0 for mharc-grub-devel@gnu.org; Mon, 30 Nov 2009 08:49:09 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF6cj-00020S-T5 for grub-devel@gnu.org; Mon, 30 Nov 2009 08:49:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF6ce-0001zz-Ec for grub-devel@gnu.org; Mon, 30 Nov 2009 08:49:04 -0500 Received: from [199.232.76.173] (port=53012 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF6ce-0001zw-9C for grub-devel@gnu.org; Mon, 30 Nov 2009 08:49:00 -0500 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:44910 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NF6cd-0001jZ-O7 for grub-devel@gnu.org; Mon, 30 Nov 2009 08:49:00 -0500 Received: by mail.pina.cat (Postfix, from userid 1000) id EA847288F3096; Mon, 30 Nov 2009 14:48:56 +0100 (CET) Date: Mon, 30 Nov 2009 14:48:56 +0100 From: Carles Pina i Estany To: The development of GNU GRUB Message-ID: <20091130134856.GA328@pinux.info> References: <20091129183936.GB19323@pina.cat> <20091129184503.GA22104@pina.cat> <20091130093949.GA6439@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091130093949.GA6439@riva.ucam.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: var=foo should be valid? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2009 13:49:06 -0000 Hello, On Nov/30/2009, Colin Watson wrote: > On Sun, Nov 29, 2009 at 06:45:03PM +0000, Carles Pina i Estany wrote: > > On Nov/29/2009, Carles Pina i Estany wrote: > (I don't know what the bug you're referring to is; both 'foo=bar' and > 'set foo=bar' seem to work OK here. I may be missing some subtle > problem, but if I'm missing it then users will too.) the problem is easy to fix and I already have the fix ready (either fix the current the bug or delete the var=foo feature) (well, as I said, maybe we can re-implement the way that it's implemented now, but we can discuss it later) The bug is that if a module hooks into a variable (e.g. gettext does, grub_register_varaible_hook) and then the user changes the value of the variable using lang=newlang, the function that gets called is executed but grub_errno is 16 (I think that was 16). Because I use grub_file_open and grub_file_open is not working if grub_errno != 0 (no error) when it's called then the gettext module cannot translate the strings using the new language. (I'm talking about the gettext module but potentially can affect other modules of course) -- Carles Pina i Estany http://pinux.info