From: Jean Delvare <khali@linux-fr.org>
To: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
List Linux Kernel <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org,
Mikko Ylinen <mikko.k.ylinen@nokia.com>
Subject: Re: [PATCH] mfd: twl4030: Driver for twl4030 madc module
Date: Mon, 30 Nov 2009 18:52:21 +0100 [thread overview]
Message-ID: <20091130185221.1215213f@hyperion.delvare> (raw)
In-Reply-To: <37786d4b0911300558i984d2bdj9b0c5617503c1950@mail.gmail.com>
On Mon, 30 Nov 2009 15:58:39 +0200, Amit Kucheria wrote:
> On Fri, Nov 27, 2009 at 9:36 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> > By the way, have you considered moving this one to drivers/hwmon ?
>
> I haven't. I moved it from i2c/chips/ to the most obvious place I
> could think of - drivers/mfd. But wasn't this the point of mfd - that
> various subcomponents drivers could live there instead of being
> scattered across the driver tree?
>
> Adding Jean to CC, if he would consider taking this driver in drivers/hwmon..
In its current form, no. This driver doesn't implement the sysfs
interface described in Documentation/hwmon/sysfs-interface. It doesn't
even register a hwmon class device. So it doesn't belong in
drivers/hwmon.
--
Jean Delvare
next prev parent reply other threads:[~2009-11-30 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 10:47 [PATCH] mfd: twl4030: Driver for twl4030 madc module Amit Kucheria
2009-11-27 19:36 ` Samuel Ortiz
2009-11-30 13:58 ` Amit Kucheria
2009-11-30 17:52 ` Jean Delvare [this message]
2009-12-01 10:19 ` Samuel Ortiz
2009-12-01 10:19 ` Samuel Ortiz
2010-01-20 12:12 ` Sergey Lapin
2010-01-20 12:12 ` Sergey Lapin
2010-01-25 9:34 ` Janakiram Sistla
2010-07-19 17:46 ` Michael Trimarchi
[not found] ` <AANLkTim2tgfAOHXXXlTBuDzEj5ndWfCX7XUXtjvkCNmq@mail.gmail.com>
2010-07-19 18:24 ` Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130185221.1215213f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mikko.k.ylinen@nokia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.