From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Anthony Liguori <anthony@codemonkey.ws>,
kvm@vger.kernel.org, Yan Vugenfirer <yvugenfi@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] virtio: set pci bus master enable bit
Date: Tue, 1 Dec 2009 10:34:01 +1030 [thread overview]
Message-ID: <200912011034.02251.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091129155200.GA6667@redhat.com>
On Mon, 30 Nov 2009 02:22:01 am Michael S. Tsirkin wrote:
> As all virtio devices perform DMA, we
> must enable bus mastering for them to be
> spec compliant.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/virtio/virtio_pci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
> index 28d9cf7..717bae1 100644
> --- a/drivers/virtio/virtio_pci.c
> +++ b/drivers/virtio/virtio_pci.c
> @@ -648,6 +648,7 @@ static int __devinit virtio_pci_probe(struct pci_dev *pci_dev,
> goto out_req_regions;
>
> pci_set_drvdata(pci_dev, vp_dev);
> + pci_set_master(pci_dev);
I can believe this, but I have no idea if it's right. I've applied it, and
hope Jesse will comment if there's something wrong with it.
Thanks,
Rusty.
next prev parent reply other threads:[~2009-12-01 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 15:52 [PATCH] virtio: set pci bus master enable bit Michael S. Tsirkin
2009-12-01 0:04 ` Rusty Russell
2009-12-01 0:04 ` Rusty Russell [this message]
2009-12-04 23:10 ` Jesse Barnes
2009-12-04 23:10 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2009-11-29 15:52 Michael S. Tsirkin
2009-11-29 15:52 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912011034.02251.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anthony@codemonkey.ws \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.