All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Kalle Valo <kalle.valo@iki.fi>, Jean Pihet <jpihet@mvista.com>,
	Vikram Pandita <vikram.pandita@ti.com>,
	Paul Walmsley <paul@pwsan.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [rfc/rft/patch 7/9] arm: omap: innovator: kill compile warning on board-innovator.c
Date: Tue, 1 Dec 2009 07:52:29 -0800	[thread overview]
Message-ID: <20091201155229.GD4348@atomide.com> (raw)
In-Reply-To: <1259672635-12306-8-git-send-email-felipe.balbi@nokia.com>

* Felipe Balbi <felipe.balbi@nokia.com> [091201 05:03]:
> that address is used by struct map_desc, which expects
> an unsigned long instead of a void __iomem *. Fix it.
> 
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  arch/arm/plat-omap/include/plat/fpga.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/include/plat/fpga.h b/arch/arm/plat-omap/include/plat/fpga.h
> index f1864a6..87a87d2 100644
> --- a/arch/arm/plat-omap/include/plat/fpga.h
> +++ b/arch/arm/plat-omap/include/plat/fpga.h
> @@ -85,7 +85,7 @@ struct h2p2_dbg_fpga {
>   *  OMAP-1510 FPGA
>   * ---------------------------------------------------------------------------
>   */
> -#define OMAP1510_FPGA_BASE		IOMEM(0xE8000000)	/* VA */
> +#define OMAP1510_FPGA_BASE		0xE8000000		/* VA */
>  #define OMAP1510_FPGA_SIZE		SZ_4K
>  #define OMAP1510_FPGA_START		0x08000000		/* PA */
>  

Instead of removing the IOMEM, can you please move it to the
OMAP1510_FPGA_START physical address where it should be?

Thanks,

Tony

  reply	other threads:[~2009-12-01 15:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 13:03 [rfc/rft/patch 0/9] omap warning cleanup Felipe Balbi
2009-12-01 13:03 ` [rfc/rft/patch 1/9] arm: omap: kill compile warning in irq.c Felipe Balbi
2009-12-01 13:03 ` [rfc/rft/patch 2/9] arm: omap: remove unused variables Felipe Balbi
2009-12-01 13:03 ` [rfc/rft/patch 3/9] arm: omap: zoom: use vmmc1 regulator supply Felipe Balbi
2009-12-01 13:08   ` Gadiyar, Anand
2009-12-01 13:10     ` Felipe Balbi
2009-12-01 13:03 ` [rfc/rft/patch 4/9] arm: omap: io: kill compile warning Felipe Balbi
2010-01-05 21:02   ` Paul Walmsley
2009-12-01 13:03 ` [rfc/rft/patch 5/9] arm: omap: kill compile warning on board-4430-sdp.c Felipe Balbi
2009-12-01 13:03 ` [rfc/rft/patch 6/9] arm: omap: gpio: kill compile warning in gpio.c Felipe Balbi
2009-12-01 13:03 ` [rfc/rft/patch 7/9] arm: omap: innovator: kill compile warning on board-innovator.c Felipe Balbi
2009-12-01 15:52   ` Tony Lindgren [this message]
2009-12-01 13:03 ` [rfc/rft/patch 8/9] arm: omap: perseus: kill compile warning on board-perseus2.c Felipe Balbi
2009-12-01 15:52   ` Tony Lindgren
2009-12-01 18:29     ` [PATCH " Felipe Balbi
2009-12-01 13:03 ` [rfc/rft/patch 9/9] arm: omap: mailbox: kill compile warning in mailbox.c Felipe Balbi
2009-12-09  0:52 ` [rfc/rft/patch 0/9] omap warning cleanup Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091201155229.GD4348@atomide.com \
    --to=tony@atomide.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=felipe.balbi@nokia.com \
    --cc=jpihet@mvista.com \
    --cc=kalle.valo@iki.fi \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.