From: Ivo van Doorn <ivdoorn@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
Benoit Papillault <benoit.papillault@free.fr>,
John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH v3 3/4] rt2x00: Reorganize L2 padding inserting function.
Date: Tue, 1 Dec 2009 22:58:22 +0100 [thread overview]
Message-ID: <200912012258.23283.IvDoorn@gmail.com> (raw)
In-Reply-To: <1259615298-2305-4-git-send-email-gwingerde@gmail.com>
On Monday 30 November 2009, Gertjan van Wingerde wrote:
> Simplify the rt2x00queue_insert_l2pad function by handling the alignment
> operations one by one. Do not special case special circumstances.
> Basically first perform header alignment, and then perform payload alignment
> (if any payload does exist). This results in a properly aligned skb.
>
> The end result is better readable code, with better results, as now L2 padding
> is inserted only when a payload is actually present in the frame.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
next prev parent reply other threads:[~2009-12-01 21:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 21:08 [PATCH v3 0/4] Further L2 padding fixes Gertjan van Wingerde
2009-11-30 21:08 ` [PATCH v3 1/4] rt2x00: " Gertjan van Wingerde
2009-11-30 21:08 ` [PATCH v3 2/4] rt2x00: Remove SKBDESC_L2_PADDED flag Gertjan van Wingerde
2009-11-30 21:08 ` [PATCH v3 3/4] rt2x00: Reorganize L2 padding inserting function Gertjan van Wingerde
2009-11-30 21:08 ` [PATCH v3 4/4] rt2x00: Only remove L2 padding in received frames if there is payload Gertjan van Wingerde
2009-12-01 19:16 ` Ivo van Doorn
2009-12-01 21:08 ` Gertjan van Wingerde
2009-12-01 21:57 ` Ivo van Doorn
2009-12-01 22:09 ` Gertjan van Wingerde
2009-12-02 7:52 ` Ivo Van Doorn
2009-12-01 21:58 ` Ivo van Doorn
2009-12-01 19:13 ` [PATCH v3 3/4] rt2x00: Reorganize L2 padding inserting function Ivo van Doorn
2009-12-01 21:05 ` Gertjan van Wingerde
2009-12-01 21:58 ` Ivo van Doorn [this message]
2009-12-01 19:07 ` [PATCH v3 2/4] rt2x00: Remove SKBDESC_L2_PADDED flag Ivo van Doorn
2009-12-01 19:07 ` [PATCH v3 1/4] rt2x00: Further L2 padding fixes Ivo van Doorn
2009-11-30 23:46 ` [rt2x00-users] [PATCH v3 0/4] " Benoit PAPILLAULT
2009-12-01 21:30 ` Gertjan van Wingerde
2009-12-02 9:54 ` Benoit PAPILLAULT
2009-12-03 9:32 ` Gertjan van Wingerde
2009-12-03 18:36 ` Ivo van Doorn
2009-12-03 21:36 ` Benoit PAPILLAULT
2009-12-04 7:53 ` Ivo Van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912012258.23283.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=benoit.papillault@free.fr \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.