Re: [PATCH v2 5/6] run test suite without dashed git-commands in PATH

[Matthew Ogilvie <mmogilvi_git@miniinfo.net>]

On Tue, Dec 01, 2009 at 09:24:46AM -0800, Jakub Narebski wrote:
> Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
> > +--with-dashes::
> > +	By default tests are run without dashed forms of
> > +	commands (like git-commit) in the PATH (it only uses
> > +	wrappers from TOP/git-bin).  Use this option to include TOP
> > +	in the PATH, which conains all the dashed forms of commands.
> > +	This option is currently implied by other options like --valgrind
> > +	and GIT_TEST_INSTALLED.
> > +
> 
> Shouldn't it be 'TOP/bin-wrappers' and not 'TOP/git-bin'?  
> Shouldn't TOP be explained somewhere, or is it obvious in the context?
> 
> s/conains/contains/.

I've appended a incremental patch for these.

Junio, do you want me to re-roll the 3 bin-wrappers patches to
include both this and the "@@ vs __" patch, or do you want
to just add or squash them in from the emails?

--
Matthew Ogilvie   [mmogilvi_git@miniinfo.net]

From: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
Date: Tue, 1 Dec 2009 22:16:19 -0700
Subject: [PATCH] t/README: fix spelling in --with-dashes documentation

Signed-off-by: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
---
 t/README |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/t/README b/t/README
index 8c5d892..dcd3ebb 100644
--- a/t/README
+++ b/t/README
@@ -78,10 +78,11 @@ appropriately before running "make".
 --with-dashes::
 	By default tests are run without dashed forms of
 	commands (like git-commit) in the PATH (it only uses
-	wrappers from TOP/git-bin).  Use this option to include TOP
-	in the PATH, which conains all the dashed forms of commands.
-	This option is currently implied by other options like --valgrind
-	and GIT_TEST_INSTALLED.
+	wrappers from ../bin-wrappers).  Use this option to include
+	the build directory (..) in the PATH, which contains all
+	the dashed forms of commands.  This option is currently
+	implied by other options like --valgrind and
+	GIT_TEST_INSTALLED.
 
 You can also set the GIT_TEST_INSTALLED environment variable to
 the bindir of an existing git installation to test that installation.
-- 
1.6.4.GIT