From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
hidehiro.kawai.ez@hitachi.com, lethal@linux-sh.org,
roland@redhat.com, vapier@gentoo.org,
Takahiro Yasui <tyasui@redhat.com>
Subject: Re: [PATCH v2] mm: Introduce coredump parameter structure
Date: Wed, 2 Dec 2009 10:50:12 +0100 [thread overview]
Message-ID: <20091202095012.GD22654@elte.hu> (raw)
In-Reply-To: <4B15B4ED.8010209@redhat.com>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Andrew Morton wrote:
> >On Sat, 28 Nov 2009 23:41:19 -0500
> >Masami Hiramatsu<mhiramat@redhat.com> wrote:
> >
> >>Introduce coredump parameter data structure (struct coredump_params)
> >>for simplifying binfmt->core_dump() arguments.
> >>
> >>Changes in v2:
> >> - Don't remove DUMP_WRITE() macro.
> >
> >What is the reason for this change?
> >
> >Please always include both the "what" and the "why" in changelog text.
>
> I see.
I think Andrew wanted to see a longer explanation about precisely what
we need for these tracepoints and what the various specific usecases are
to utilize it.
I.e. a basic cost/benefit analysis is needed. By looking at the patch we
can see the cost - but you have to counter-balance that with enough
stuff in the 'benefits' column of the equation.
Ingo
next prev parent reply other threads:[~2009-12-02 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 22:12 + binfmt-introduce-coredump-parameter-structure.patch added to -mm tree akpm
2009-11-26 8:53 ` KOSAKI Motohiro
2009-11-26 15:50 ` Masami Hiramatsu
2009-11-26 16:51 ` Oleg Nesterov
2009-11-29 3:59 ` Masami Hiramatsu
2009-11-29 4:39 ` [PATCH v2] mm: Introduce coredump parameter structure Masami Hiramatsu
2009-11-29 4:41 ` Masami Hiramatsu
2009-11-29 15:10 ` [PATCH][RFC] tracepoint: signal coredump (Re: [PATCH v2] mm: Introduce coredump parameter structure) Masami Hiramatsu
2009-12-02 20:46 ` [PATCH v2] [RFC] tracepoint: Add signal coredump tracepoint Masami Hiramatsu
2009-12-03 10:39 ` Ingo Molnar
2009-12-03 11:32 ` Masami Hiramatsu
2009-12-05 7:16 ` Ingo Molnar
2009-12-07 17:19 ` Masami Hiramatsu
2009-12-05 7:18 ` KOSAKI Motohiro
2009-12-07 15:25 ` Masami Hiramatsu
2009-12-08 1:51 ` KOSAKI Motohiro
2009-12-08 20:40 ` [PATCH v3] " Masami Hiramatsu
2009-12-09 5:34 ` KOSAKI Motohiro
2009-12-09 16:07 ` Masami Hiramatsu
2009-12-09 16:16 ` Masami Hiramatsu
2009-12-09 20:38 ` [PATCH v4] " Masami Hiramatsu
2009-12-10 0:09 ` KOSAKI Motohiro
2009-12-02 0:18 ` [PATCH v2] mm: Introduce coredump parameter structure Andrew Morton
2009-12-02 0:27 ` KOSAKI Motohiro
2009-12-02 0:29 ` Masami Hiramatsu
2009-12-02 9:50 ` Ingo Molnar [this message]
2009-12-02 18:07 ` Masami Hiramatsu
2009-12-02 0:41 ` [PATCH v2] [RESEND] " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202095012.GD22654@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=tyasui@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.