From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NFoIS-000333-IF
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:27:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NFoIO-00030o-TE
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:27:04 -0500
Received: from [199.232.76.173] (port=37332 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NFoIO-00030Y-8R
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:27:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:62418)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1NFoIN-0006UT-SX
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:27:00 -0500
Date: Wed, 2 Dec 2009 14:26:53 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20091202122653.GD9537@redhat.com>
References: <1259671897-22232-1-git-send-email-glommer@redhat.com>
	<1259671897-22232-2-git-send-email-glommer@redhat.com>
	<1259671897-22232-3-git-send-email-glommer@redhat.com>
	<1259671897-22232-4-git-send-email-glommer@redhat.com>
	<1259671897-22232-5-git-send-email-glommer@redhat.com>
	<1259671897-22232-6-git-send-email-glommer@redhat.com>
	<20091202104826.GA9537@redhat.com>
	<5d6222a80912020322s49e45015ga7b012ddd066c93b@mail.gmail.com>
	<4B16592E.5030201@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B16592E.5030201@siemens.com>
Subject: [Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers
 instead of just mp_state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: aliguori@us.ibm.com, Glauber Costa <glommer@gmail.com>, Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org, agraf@suse.de, avi@redhat.com

On Wed, Dec 02, 2009 at 01:10:22PM +0100, Jan Kiszka wrote:
> Glauber Costa wrote:
> >>> +{
> >>> +    if (kvm_enabled()) {
> >> Is this ever called or intended to be called when kvm is disabled?
> >>
> >>> +        kvm_cpu_flush_state(env);
> >>> +    }
> > 
> > I don't think so. But this is here for consistency with its synchronize brother.
> 
> Ack. As soon as someone starts to use this generic service outside code
> that is only built under CONFIG_KVM or called when kvm is enabled,
> things will break.
> 
We can add the check when adding first such user. Code outside
CONFIG_KVM can't use this since the function is in kvm.h header.
I don't have really strong opinion about that. I personally use
kvm_enabled() as a hint that code is generic for kvm and non-kvm
case when reading code.

--
			Gleb.