From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937AbZLBNNY (ORCPT ); Wed, 2 Dec 2009 08:13:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753707AbZLBNNY (ORCPT ); Wed, 2 Dec 2009 08:13:24 -0500 Received: from one.firstfloor.org ([213.235.205.2]:39972 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbZLBNNX (ORCPT ); Wed, 2 Dec 2009 08:13:23 -0500 Date: Wed, 2 Dec 2009 14:13:30 +0100 From: Andi Kleen To: Wu Fengguang Cc: Andi Kleen , Andrew Morton , Nick Piggin , linux-mm@kvack.org, LKML Subject: Re: [PATCH 10/24] HWPOISON: remove the free buddy page handler Message-ID: <20091202131330.GF18989@one.firstfloor.org> References: <20091202031231.735876003@intel.com> <20091202043044.878843398@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091202043044.878843398@intel.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2009 at 11:12:41AM +0800, Wu Fengguang wrote: > The buddy page has already be handled in the very beginning. > So remove redundant code. I think I prefer the table to be complete, even if some of the cases might not happen currently. A BUG() would be reasonable though. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id B7AF4600762 for ; Wed, 2 Dec 2009 08:13:32 -0500 (EST) Date: Wed, 2 Dec 2009 14:13:30 +0100 From: Andi Kleen Subject: Re: [PATCH 10/24] HWPOISON: remove the free buddy page handler Message-ID: <20091202131330.GF18989@one.firstfloor.org> References: <20091202031231.735876003@intel.com> <20091202043044.878843398@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091202043044.878843398@intel.com> Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: Andi Kleen , Andrew Morton , Nick Piggin , linux-mm@kvack.org, LKML List-ID: On Wed, Dec 02, 2009 at 11:12:41AM +0800, Wu Fengguang wrote: > The buddy page has already be handled in the very beginning. > So remove redundant code. I think I prefer the table to be complete, even if some of the cases might not happen currently. A BUG() would be reasonable though. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org