From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jan Krüger" <jk@jk.gs>, "Jeff King" <peff@peff.net>,
"Jan Nieuwenhuizen" <janneke-list@xs4all.nl>,
"Tomas Carnecky" <tom@dbservice.com>,
"git list" <git@vger.kernel.org>
Subject: Re: [PATCH] pull: clarify advice for the unconfigured error case
Date: Wed, 2 Dec 2009 19:26:14 -0600 [thread overview]
Message-ID: <20091203012535.GA16259@progeny.tock> (raw)
In-Reply-To: <7vk4x57z4e.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> From: Jan Krüger <jk@jk.gs>
>>
>> When pull --rebase fails because it cannot find what branch to
>> merge against, the error message implies we are trying to merge.
>> Say "rebase against" instead of "merge with" to avoid confusion.
[...]
> Is this a good replacement for 31971b3 (git-pull.sh --rebase: overhaul
> error handling when no candidates are found, 2009-11-12) that is on 'pu'
Yes, that is the intent.
> and does the lack of follow-up mean everybody involved in the discussion
> is happy with this version?
I’m not sure. I know I like it. :-)
I was the only one with nitpicks about the wording (sorry). Re
whether to use configuration file syntax or a 'git config' command
line snippet, it seemed like there was some consensus once it was
clear that the user would have to modify the lines anyway to fill in
the right values. But others can speak up if this seems wrong.
Hope that helps,
Jonathan
next prev parent reply other threads:[~2009-12-03 1:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 13:22 Unhelpful "branch.master.remote = <nickname>" advice? Jan Nieuwenhuizen
2009-11-11 14:08 ` Tomas Carnecky
[not found] ` <1257965806.26362.132.camel@heerbeest>
2009-11-11 19:10 ` Tomas Carnecky
2009-11-11 19:34 ` Jan Nieuwenhuizen
2009-11-11 20:32 ` Tomas Carnecky
2009-11-12 14:17 ` Jan Nieuwenhuizen
2009-11-12 14:53 ` [PATCH] git-pull.sh: overhaul error handling when no candidates are found Jan Krüger
2009-11-12 15:06 ` Jeff King
2009-11-12 15:25 ` Jan Krüger
2009-11-12 15:28 ` Jeff King
2009-11-12 16:08 ` [PATCH v2] git-pull.sh --rebase: " Jan Krüger
2009-11-13 4:07 ` Jonathan Nieder
2009-11-27 14:17 ` [PATCH] pull: clarify advice for the unconfigured error case Jonathan Nieder
2009-12-02 23:08 ` Junio C Hamano
2009-12-03 1:26 ` Jonathan Nieder [this message]
2009-12-03 1:43 ` Jeff King
2009-12-03 8:49 ` Jan Nieuwenhuizen
2009-12-03 10:51 ` Jan Krüger
2009-12-07 0:29 ` Junio C Hamano
2009-11-15 9:08 ` [PATCH v2] git-pull.sh --rebase: overhaul error handling when no candidates are found Junio C Hamano
2009-11-12 14:56 ` Unhelpful "branch.master.remote = <nickname>" advice? Björn Steinbrink
2009-11-12 15:03 ` Tomas Carnecky
2009-11-18 12:29 ` [PATCH] Makefile: add uninstall target. Fixes elementary good cleaning manners Jan Nieuwenhuizen
2009-11-18 13:28 ` Matthieu Moy
2009-11-11 14:13 ` Unhelpful "branch.master.remote = <nickname>" advice? Jan Krüger
2009-11-11 19:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203012535.GA16259@progeny.tock \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=janneke-list@xs4all.nl \
--cc=jk@jk.gs \
--cc=peff@peff.net \
--cc=tom@dbservice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.