Re: [PATCH v3 0/4] OMAP: McBSP: Use register cache

[Jarkko Nikula <jhnikula@gmail.com>]

On Tue, 1 Dec 2009 04:10:07 +0100
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:

> Change the way McBSP registers are maintained: store values written to the
> device in a cache in order to  make use of those cached values when
> convenient.
> 
> This could help for developing the McBSP context save/restore features, as
> well as solve the problem of possible register corruption experienced on
> OMAP1510 based Amstrad Delta board, at least.
> 
> Janusz Krzysztofik (4):
> 	OMAP: McBSP: Use macros for all register read/write operations
> 	OMAP: McBSP: Prepare register read/write macros API for caching
> 	OMAP: McBSP: Introduce caching in register write operations
> 	OMAP: McBSP: Use cache when modifying individual register bits
> 
>  arch/arm/plat-omap/include/plat/mcbsp.h |    5
>  arch/arm/plat-omap/mcbsp.c              |  397 ++++++++++++++++++++++++---------------------------
>  2 files changed, 198 insertions(+), 204 deletions(-)
> 
Looks good to me and audio works fine with the Beagle. One minor
comment to the patch 3.

-- 
Jarkko