From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGAMV-0003Yp-RG
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:00:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGAMO-0003WL-9r
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:00:40 -0500
Received: from [199.232.76.173] (port=44981 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGAMN-0003Vs-RN
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:00:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:6589)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NGAMN-0006gE-6U
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:00:35 -0500
Date: Thu, 3 Dec 2009 13:57:29 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 0/9] in-kernel irqchip, new spin
Message-ID: <20091203115729.GC7352@redhat.com>
References: <1259761575-3953-1-git-send-email-glommer@redhat.com>
	<20091203102701.GC6752@redhat.com>
	<5d6222a80912030342m499eb913lff5fc7a21b142718@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5d6222a80912030342m499eb913lff5fc7a21b142718@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, avi@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, Dec 03, 2009 at 09:42:02AM -0200, Glauber Costa wrote:
> >
> > Does msix work with this patchset when in-kernel irqchip
> > is enabled?
> 
> Haven't tested. But since I see that msix need some special code in qemu-kvm,
> it probably won't. But I assume we can just add a patch ontop of this to add
> that code and make it work, right?

Sure. However - are you making in-kernel irqchip the default?
If so, I think the best way to do it would be:
1. add in-kernel irqchip, off by default
2. fix msix with in-kernel
3. make in-kernel on by default

Otherwise you hurt bisectability.

> -- 
> Glauber  Costa.
> "Free as in Freedom"
> http://glommer.net
> 
> "The less confident you are, the more serious you have to act."