From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: [PATCH] libxenlight: clone context to avoid GC corruption Date: Thu, 3 Dec 2009 15:11:10 +0000 Message-ID: <20091203151110.GA16650@gwig.uk.xensource.com> References: <4B16E586.7060505@lagarcavilla.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <4B16E586.7060505@lagarcavilla.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andres Lagar-Cavilla Cc: "xen-devel@lists.xensource.com" , Vincent Hanquez , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, Dec 02, 2009 at 10:09:10PM +0000, Andres Lagar-Cavilla wrote: > Provide a function to clone a context. This is necessary > because simply copying the structs will eventually > corrup the GC: maxsize is updated in the cloned context > but not in the originating one, yet they have the same > array of referenced pointers alloc_ptrs. I think this doesn't answer the question of why you need this function at all. I don't think you should clone the context nor share it. -- Vincent